After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649902 - Implement AtkTextSelection
Implement AtkTextSelection
Status: RESOLVED OBSOLETE
Product: atk
Classification: Platform
Component: atk
git master
Other Linux
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks: 638537
 
 
Reported: 2011-05-10 14:51 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2021-06-10 11:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch. (2.06 KB, patch)
2011-07-08 10:21 UTC, Mike Gorse
none Details | Review

Description Joanmarie Diggs (IRC: joanie) 2011-05-10 14:51:41 UTC
Conclusion from the ATK Hackfest regarding bug 638378:

* We are planning on notifying ATs of property changes via property-change events which contain the old and new information. Changes in text selection apply here as well.

* We will need an object ('AtkTextSelection') which reflects a current text selection.

* Properties needed:
  * Start offset (where the caret was)
  * End offset (where the caret is)
  * Selection number (because AtkText supports multiple selections)

* Joanie would also like to have the string if possible and makes sense. :-)
Comment 1 André Klapper 2011-06-23 22:06:14 UTC
[Mass-reassigning open atk bug reports for better trackability as requested in https://bugzilla.gnome.org/show_bug.cgi?id=653179 .
PLEASE NOTE:
If you have watched the previous assignee of this bug report as a workaround for actually getting notified of changes in atk bugs, you yourself will now have to add atk-maint@gnome.bugs to your watchlist at the bottom of https://bugzilla.gnome.org/userprefs.cgi?tab=email to keep watching atk bug reports in GNOME Bugzilla.
Sorry for the noise: Feel free to filter for this comment in order to mass-delete the triggered bugmail.]
Comment 2 Mike Gorse 2011-07-08 10:21:55 UTC
Created attachment 191511 [details] [review]
Patch.
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2011-07-08 16:59:28 UTC
It seems ok, but I would like to test it first, and I don't have a proper environment right now.

I will try to do that during the weekend.
Comment 4 Frederik Gladhorn 2012-01-20 17:07:42 UTC
I do not think this is needed.

In the text interface you have:
selection to give start and end offset for the selection
text to get the text between two offsets

For the notification:
it would be possible to use detail1,2 for the text offsets and the variant for the text change in the TextSelectionChanged signal.

Currently this signal always sends 0,0,"" as parameters.
Comment 5 André Klapper 2012-02-06 15:52:53 UTC
(In reply to comment #3)
> I would like to test it first, and I don't have a proper environment right now.
> I will try to do that during the weekend.

API: Did you have a chance to do so?
Comment 6 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-02-06 16:01:02 UTC
(In reply to comment #5)
> (In reply to comment #3)
> > I would like to test it first, and I don't have a proper environment right now.
> > I will try to do that during the weekend.
> 
> API: Did you have a chance to do so?

We briefly talked about this during the last ATK hackfest. Comment 4 is a consequence of that. And as that comment say, right now we are not sure if this is required. We would need to re-think this, so we can retake this in the future if required.
Comment 7 André Klapper 2021-06-10 11:25:39 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version of atk, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a ticket at
  https://gitlab.gnome.org/GNOME/atk/-/issues/

Thank you for your understanding and your help.