GNOME Bugzilla – Bug 649783
Make sure all lines are ellipsized
Last modified: 2018-05-22 13:00:24 UTC
All lines that are too long should be ellipsized when ellipsizing is enabled. Not just those lines where we thought they'd need to be in advance. It might turn out that a word is too long so that we cannot wrap it. In that case we still want to break as soon as possible, but still ellipsize the line.
Created attachment 187498 [details] [review] layout: Make sure all lines are ellipsized
This is tested by GTK's tests/reftest/label-sizing.ui reftest btw, which currently fails. So either we need to adapt the reftest to current Pango behavior so distcheck actually starts passing, or we need this to get fixed rather quickly. Or Matthias is going to pitchfork me for breaking distcheck. :)
Can you suggest test case using pango-view?
pango-view --wrap=word --height=200 --width=100 --ellipsize=end -t "Supercalifragelisticexpialidocious is a long word." is an obvious case. Pretty much everything is ok that matches pango-view --wrap=word --ellipsize=end --height=$BIG --width=$SMALLER_AS_LARGEST_WORD
Any news on this ? make check still failing in gtk...
As discussed on #gtk+ today, the pango patch needs more consideration before it goes in, because it changes the semantics of the pango api. We first need to define the desired behavior before any such change can be made. I'll draft something and post for comments. What should happen to the gtk test or implementation is out of my scope.
I've changed the gtk test now to mirror current Pango behavior. See http://git.gnome.org/browse/gtk+/commit/?id=ace4faa4e22ddfb6153e18c3f4c1dfc5f3ee8194 for the commit.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/pango/issues/192.