Bug 648739 – Some icons randomly appear twice

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 648739 - Some icons randomly appear twice


Summary:	Some icons randomly appear twice


Status:	RESOLVED FIXED

Product:	gnome-shell
Classification:	Core
Component:	general
Version:	3.0.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	gnome-shell-maint
QA Contact:	gnome-shell-maint

URL:
Whiteboard:

Duplicates:	648813 (view as bug list)
Depends on:
Blocks:

Reported:	2011-04-27 08:39 UTC by Elad Alfassa
Modified:	2011-05-04 07:53 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Screenshot (697.51 KB, image/png) 2011-04-27 08:39 UTC, Elad Alfassa		Details
appDisplay: Fix off-by-one when incrementally adding application icons (1.02 KB, patch) 2011-04-27 11:52 UTC, Owen Taylor	committed	Details \| Review

Description Elad Alfassa 2011-04-27 08:39:51 UTC

Created attachment 186718 [details]
Screenshot

Probably caused by http://git.gnome.org/browse/gnome-shell/commit/?id=7813c5b93f6bcde8c4beae286e82bfc472b2b656

Comment 1 Owen Taylor 2011-04-27 11:52:17 UTC

Created attachment 186726 [details] [review]
appDisplay: Fix off-by-one when incrementally adding application icons

A "cosmetic" code arrangement I requested in code review resulted
in one too few items being removed from the queue for each incremental
chunk of icons added. Fix.

Comment 2 drago01 2011-04-27 11:58:14 UTC

Review of attachment 186726 [details] [review]:

Looks good.

Comment 3 Colin Walters 2011-04-27 21:41:42 UTC

*** Bug 648813 has been marked as a duplicate of this bug. ***

Comment 4 drago01 2011-05-04 07:53:36 UTC

Patch has been pushed as c0dc363a3d -> closing.