GNOME Bugzilla – Bug 646169
Atomix GtkObjectRemove
Last modified: 2015-01-13 01:17:22 UTC
GtkObject is gone in Gtk3
Created attachment 184638 [details] [review] removal of GtkObject hi, i am proposing a path for this Goal. i am waiting for reviews
Hello Alex, thanks for the patch. This patch can only be applied if atomix depends on GTK+3, and unfortunately is not the case. (there is not gtk_widget_destroy() in GTK+2, for example). Anyway, you can make the code conditional with GTK_CHECK_VERSION(), but I'm not very sure if there is something working on port atomix to GTK+3 (maybe you? ;))
Thank's for the idea with GTK_CHECK_VERSION(). In 2-3 days , i will submit a patch with it . As for porting atomix to GTK+3 I would really like to do that, the problem is that i have little time right now, but i will propose it as a project for a open-source development course held in my university.
Instead of GtkWidgetClass::destroy (gtk3 only) you could use GObjectClass::dispose (which is better anyway :).
Created attachment 185018 [details] [review] making use of GObjectClass dispose hi, here is the other version I promised. Hope it's better
If someone is applying Atomix patches it would be great if you could also check bugzilla bug 313130 and see if the patch there can be applied too. https://bugzilla.gnome.org/show_bug.cgi?id=313130
Based on the comments this would be fixed by a GTK3 port, so marking this as a duplicate of the GTK3 port bug. Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find. *** This bug has been marked as a duplicate of bug 742827 ***