GNOME Bugzilla – Bug 645762
Fix Python Console plugin
Last modified: 2011-03-27 15:36:35 UTC
Patches coming up to fix some blocker issues which are stopping the pythonconsole plugin working at all.
Created attachment 184306 [details] [review] pythonconsole: Fix calls to Gtk.Action() This patch fixes the pythonconsole plugin's use of Gtk.Action(). We were calling it without passing the stock_id parameter, which is missing an allow-none annotation. Not passing the parameter causes a Python error, meaning the plugin can't be activated.
Created attachment 184307 [details] [review] pythonconsole: Port fixes to key event handling from gedit's pythonconsole Patch to fix the key event handling in the pythonconsole plugin. Changes to the GIR file for GDK since the plugin was last tested mean that without these changes, no commands are ever recognised by the plugin and it's effectively useless. Based on the changes in the corresponding plugin in gedit: • http://git.gnome.org/browse/gedit/commit/plugins/pythonconsole/pythonconsole/console.py?id=da49b588a394717b5ea0a3f9e6a823a86e62feae • http://git.gnome.org/browse/gedit/commit/plugins/pythonconsole/pythonconsole/console.py?id=ba74278347888e4a16f3a0fee2a359b7f2bcde8b
Comment on attachment 184307 [details] [review] pythonconsole: Port fixes to key event handling from gedit's pythonconsole Committed with a fixed up commit message.
I'm leaving this opened. Ctrl+D doesn't seem to close the console anymore, and completion with tab seems to be broken. I never used the console before. Are those expected (in which case I'll file a separate bug), or are they regressions?
(In reply to comment #4) > I'm leaving this opened. Ctrl+D doesn't seem to close the console anymore, and > completion with tab seems to be broken. I never used the console before. Are > those expected (in which case I'll file a separate bug), or are they > regressions? I don't think Ctrl+D ever closed the console — at least, the code in the “destroy” method has always been commented out. I don't think tab completion ever existed. What would be more useful in the next cycle is to merge our pythonconsole plugin with the one in gedit, probably by moving them both to libpeas or something.
Fair enough, filed as Bug 645831.