After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643486 - Follow mockups for blink time
Follow mockups for blink time
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Universal Access
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on: 643487
Blocks:
 
 
Reported: 2011-02-28 13:54 UTC by Bastien Nocera
Modified: 2016-09-08 12:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-keyboard-Follow-mockups-for-blink-time.patch (6.70 KB, patch)
2011-02-28 13:54 UTC, Bastien Nocera 		needs-work Details | Review
Based on the previous patch, this patch fixes the alignment of the labels so (17.81 KB, patch)
2012-11-21 12:39 UTC, Thomas Wood 		needs-work Details | Review

Description Bastien Nocera 2011-02-28 13:54:22 UTC 
.
Comment 1 Bastien Nocera 2011-02-28 13:54:59 UTC 
Created attachment 182089 [details] [review]
0001-keyboard-Follow-mockups-for-blink-time.patch
Comment 2 Robert Roth 2011-07-08 13:38:25 UTC 
The patch attached is marked as needswork, but I can't see any reasoning. What's wrong with it, and what should be done to improve it to have it merged in trunk?
Comment 3 Matthias Clasen 2011-08-24 13:07:50 UTC 
It is mentioned in the patch: the scale doesn't line up with the labels
Comment 4 André Klapper 2011-08-24 13:19:48 UTC 
Removing GNOME Target as per IRC discussion with hadess on #gnome-hackers.
You can use Target Milestones for project specific planning (you can set them up yourself if you are listed as module maintainer in Bugzilla).
Comment 5 Thomas Wood 2012-11-21 12:39:12 UTC 
Created attachment 229571 [details] [review]
Based on the previous patch, this patch fixes the alignment of the labels so

that they align with the top of the slider.

This patch also fixes the logic so that the "Off" mark is placed at the correct
end of the scale (the scale is inverted, so value for "Off" must be larger than
the maximum value rather than smaller than the minimum value).
Comment 6 Bastien Nocera 2012-11-21 21:54:21 UTC 
I don't really like the way this is implemented. We probably have a number of other places where the label for a scale doesn't line up. I would prefer if we had access to more details inside the GtkScale to allow us to do that cleanly.
Comment 7 Bastien Nocera 2016-09-08 12:47:12 UTC 
Cursor blink setup is now done in the Universal Access panel, closing.