After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641629 - configure should honor aclocal flags ACLOCAL_FLAGS
configure should honor aclocal flags ACLOCAL_FLAGS
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] Builds
0.x.x [obsolete]
Other All
: Normal enhancement
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 641445
 
 
Reported: 2011-02-05 23:40 UTC by Craig Keogh
Modified: 2011-02-07 22:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Honor aclocal flags (643 bytes, patch)
2011-02-05 23:42 UTC, Craig Keogh 		committed Details | Review
Remove configure.in ACLOCAL_FLAGS, now in Makefile.am (795 bytes, patch)
2011-02-05 23:45 UTC, Craig Keogh 		committed Details | Review

Description Craig Keogh 2011-02-05 23:40:32 UTC 
I'm building nautilus via JHBuild. nautilus builds
successfully. If upstream then updates configure.ac, then I run 'make', which
attempts a reconfigure, but fails.

This is because JHBuild sets ACLOCAL_FLAGS to include the sandbox (e.g. -I
/opt/gnome/share/aclocal). One may argue it is silly for JHBuild to require
every module to support ACLOCAL_FLAGS, but there isn't a way around it until
automake-1.12 is out - which includes support for ACLOCAL_PATH. Further details
in the JHBuild bug 634617.

The build failure is:
make  V=1
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/Oxyde/gnome/nautilus/missing --run aclocal-1.11 -I m4
configure.in:58: warning: macro `AM_GLIB_GNU_GETTEXT' not found in library
configure.in:20: warning: AC_INIT: not a literal: http://bugzilla.gnome.org/enter_bug.cgi?product=nautilus
 cd . && /bin/sh /home/Oxyde/gnome/nautilus/missing --run automake-1.11 --gnu
configure.in:20: warning: AC_INIT: not a literal: http://bugzilla.gnome.org/enter_bug.cgi?product=nautilus
eel/Makefile.am:87: `%'-style pattern rules are a GNU make extension
eel/Makefile.am:91: `%'-style pattern rules are a GNU make extension
eel/Makefile.am:92: subst -,_,$*: non-POSIX variable name
eel/Makefile.am:92: (probably a GNU make extension)
libnautilus-extension/Makefile.am:67: HAVE_INTROSPECTION does not appear in AM_CONDITIONAL
libnautilus-extension/Makefile.am:78: addprefix $(srcdir: non-POSIX variable name
libnautilus-extension/Makefile.am:78: (probably a GNU make extension)
libnautilus-private/Makefile.am:199: `%'-style pattern rules are a GNU make extension
libnautilus-private/Makefile.am:200: subst -,_,$*: non-POSIX variable name
libnautilus-private/Makefile.am:200: (probably a GNU make extension)
libnautilus-private/Makefile.am:202: `%'-style pattern rules are a GNU make extension
src/Makefile.am:187: `%'-style pattern rules are a GNU make extension
src/Makefile.am:191: `%'-style pattern rules are a GNU make extension
src/Makefile.am:192: subst -,_,$*: non-POSIX variable name
src/Makefile.am:192: (probably a GNU make extension)
make: *** [Makefile.in] Error 1
Comment 1 Craig Keogh 2011-02-05 23:42:36 UTC 
Created attachment 180195 [details] [review]
Honor aclocal flags
Comment 2 Craig Keogh 2011-02-05 23:45:34 UTC 
Created attachment 180196 [details] [review]
Remove configure.in ACLOCAL_FLAGS, now in Makefile.am


This optional patch removes the ACLOCAL_FLAGS support in configure.in.
ACLOCAL_FLAGS support is in Makefile.am as per attachment 180195 [details] [review].
See bug 640883 comment 4 by Christian Persch for more information.
Comment 3 Cosimo Cecchi 2011-02-07 17:06:46 UTC 
Please push to master.
Comment 4 Craig Keogh 2011-02-07 22:02:15 UTC 
Comment on attachment 180196 [details] [review]
Remove configure.in ACLOCAL_FLAGS, now in Makefile.am

Committed.
http://git.gnome.org/browse/nautilus/commit/?id=43573325a03536a93869f0a080dc0b2257e7e258