After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640882 - configure should honor aclocal flags ACLOCAL_FLAGS
configure should honor aclocal flags ACLOCAL_FLAGS
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks: 641445
 
 
Reported: 2011-01-29 06:39 UTC by Craig Keogh
Modified: 2011-02-19 03:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Honor aclocal flags (578 bytes, patch)
2011-01-29 06:43 UTC, Craig Keogh 		none Details | Review
Honor aclocal flags (564 bytes, patch)
2011-02-02 11:29 UTC, Craig Keogh 		committed Details | Review

Description Craig Keogh 2011-01-29 06:39:11 UTC 
I'm building gnome-settings-daemon via JHBuild. gnome-settings-daemon builds successfully. If upstream then updates configure.ac, the build fails:

make  V=1
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/Oxyde/gnome/gnome-settings-daemon/missing --run aclocal-1.11 
configure.ac:37: error: possibly undefined macro: AM_GLIB_GNU_GETTEXT

This is because JHBuild sets ACLOCAL_FLAGS to include the sandbox (e.g. -I /opt/gnome/share/aclocal). One may argue it is silly for JHBuild to require every module to support ACLOCAL_FLAGS, but there isn't a way around it until automake-1.12 is out - which includes support for ACLOCAL_PATH. Further details in the JHBuild bug 634617.
Comment 1 Craig Keogh 2011-01-29 06:43:18 UTC 
Created attachment 179575 [details] [review]
Honor aclocal flags
Comment 2 Craig Keogh 2011-02-02 11:29:36 UTC 
Created attachment 179869 [details] [review]
Honor aclocal flags

My last patch was incorrect. Thanks to Christian Persch, as I learnt in bug 640883, this is the correct way to honor aclocal flags.