After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635399 - Add C include information to GIRs
Add C include information to GIRs
Status: RESOLVED DUPLICATE of bug 654689
Product: pango
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks: 635330
 
 
Reported: 2010-11-21 00:35 UTC by Evan Nemerson
Modified: 2011-07-22 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add C include and exported packages information to GIRs (3.31 KB, patch)
2010-11-21 00:41 UTC, Evan Nemerson 		none Details | Review
Build GIR correctly when pango isn't already installed (1.72 KB, patch)
2011-07-17 19:47 UTC, Evan Nemerson 		none Details | Review

Description Evan Nemerson 2010-11-21 00:35:26 UTC 
The GIRs distributed by pango do not currently include information on which C headers to include. This information is important for generating Vala bindings from the GIRs.
Comment 1 Evan Nemerson 2010-11-21 00:41:38 UTC 
Created attachment 174937 [details] [review]
Add C include and exported packages information to GIRs
Comment 2 Behdad Esfahbod 2010-11-21 03:26:09 UTC 
Looks good.  Please commit to master.
Comment 3 Luca Bruno 2011-07-13 07:10:38 UTC 
commit f42a399b94d123f2153ce874825aed414666d9bc
Author: Evan Nemerson <evan@coeus-group.com>
Date:   Sat Nov 20 16:39:42 2010 -0800

    Bug 635399 - Add C include and exported packages information to GIRs
Comment 4 Craig Keogh 2011-07-17 04:49:37 UTC 
Commit f42a39 [1] is causing the build to fail. A successful build of pango must NOT exist in --prefix to reproduce. The error is:

/opt/gnome/bin/g-ir-scanner  --warn-all --add-include-path=. --add-include-path=. --namespace=PangoXft --nsversion=1.0 --libtool="/bin/sh ../libtool" --pkg=gobject-2.0 --pkg=freetype2 --include=GObject-2.0 --include=xft-2.0 --include=xlib-2.0 --pkg-export=pangoxft  --library=libpangoxft-1.0.la --include-uninstalled=./PangoFT2-1.0.gir --c-include "pango/pangoxft.h" -I..   pangoxft.h pangoxft-render.h pangoxft-font.c pangoxft-fontmap.c pangoxft-render.c libpangoxft-1.0.la PangoFT2-1.0.gir --output PangoXft-1.0.gir
Package pango was not found in the pkg-config search path.
Perhaps you should add the directory containing `pango.pc'
to the PKG_CONFIG_PATH environment variable
No package 'pango' found
In file included from ../pango/pango-font.h:25:0,
                 from ../pango/pango-context.h:25,
                 from /home/oxyde/gnome/pango/pango/pangoxft.h:26,
                 from <stdin>:4:
../pango/pango-coverage.h:25:18: fatal error: glib.h: No such file or directory
compilation terminated.
Error while processing the source.
make[4]: *** [PangoXft-1.0.gir] Error 1
make[4]: Leaving directory `/home/oxyde/gnome/pango/pango'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/oxyde/gnome/pango/pango'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/oxyde/gnome/pango/pango'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/oxyde/gnome/pango'
make: *** [all] Error 2

[1] http://git.gnome.org/browse/pango/commit/?id=f42a399b94d123f2153ce874825aed414666d9bc
Comment 5 Evan Nemerson 2011-07-17 19:47:46 UTC 
Created attachment 192143 [details] [review]
Build GIR correctly when pango isn't already installed

I think this should do the trick.
Comment 6 Colin Walters 2011-07-22 15:05:39 UTC 

*** This bug has been marked as a duplicate of bug 654689 ***