After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635361 - Document the use of color labels for accounts
Document the use of color labels for accounts
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Documentation
git-master
Other All
: Normal normal
: ---
Assigned To: Cristian Marchi
Yawar Amin
Depends on:
Blocks:
 
 
Reported: 2010-11-20 17:32 UTC by Geert Janssens
Modified: 2018-06-29 22:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
content patch (14.33 KB, patch)
2010-11-25 18:28 UTC, Cristian Marchi
accepted-commit_now Details | Review
markup patch (9.64 KB, patch)
2010-11-25 18:29 UTC, Cristian Marchi
reviewed Details | Review
other sections (3.04 KB, patch)
2010-11-25 18:29 UTC, Cristian Marchi
accepted-commit_now Details | Review

Description Geert Janssens 2010-11-20 17:32:06 UTC
Accounts can have a colour assigned to them that is used the colour register tabs (and accounts in the account view also ?). This has been added somewhere in 2.3.x (I'd have to look it up, but I believe somewhere around 2.3.9).

I didn't find this reflected in the documentation. For example, guide section 3.3.2 shows a New Account dialog, but this is missing the account color selector. There may be other places in guide and help that need to be updated for this.
Comment 1 Cristian Marchi 2010-11-21 08:03:57 UTC
Thanks for pointing this out. I'm going to work on this bug. In the coming days I will post here a patch for review.
Comment 2 Cristian Marchi 2010-11-25 18:28:42 UTC
Created attachment 175266 [details] [review]
content patch
Comment 3 Cristian Marchi 2010-11-25 18:29:04 UTC
Created attachment 175267 [details] [review]
markup patch
Comment 4 Cristian Marchi 2010-11-25 18:29:35 UTC
Created attachment 175268 [details] [review]
other sections

I attach for review some patches for the Accounts chapter of the help where the new account screen is described. I will also update the guide figure you are referring to.
first patch corrects and update the content, the second one add and corrects markup and the last one is about the edit and create account sections in the same help chapter.
Comment 5 Geert Janssens 2010-11-25 20:23:31 UTC
Comment on attachment 175267 [details] [review]
markup patch

It seems you are removing the indents for some paragraph content (<para> tags) and keeping them for some other. Is there some logic behind this ?

Other than that, this patch is fine to commit IMO.
Comment 6 Geert Janssens 2010-11-25 20:25:38 UTC
Comment on attachment 175268 [details] [review]
other sections

This patch as well seems to mostly remove paragraph indents. I have no problems with that at all, I just like to understand the logic behind it for if I make changes myself.
Comment 7 Cristian Marchi 2010-11-26 21:09:52 UTC
I tend to move the <para> tags on the same column of the following text line. And I try use always two spaces for intend. Maybe I skipped these (personal) rules sometime but that's only because I didn't noticed!
Is there an indentation standard for docbook or for GnuCash documentation?
Comment 8 John Ralls 2018-06-29 22:47:44 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=635361. Please update any external references or bookmarks.