After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635332 - Include C header information in GIR
Include C header information in GIR
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: build
unspecified
Other Linux
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks: 635330
 
 
Reported: 2010-11-20 06:31 UTC by Evan Nemerson
Modified: 2012-07-18 17:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Include C header information in GIR (829 bytes, patch)
2010-11-20 06:34 UTC, Evan Nemerson 		none Details | Review
Updated patch (851 bytes, patch)
2012-06-26 06:48 UTC, Jürg Billeter 		committed Details | Review

Description Evan Nemerson 2010-11-20 06:31:39 UTC 
Atk-1.0.gir does not currently include information on which C header to include. Vala needs this information to properly generate bindings from the GIR.
Comment 1 Evan Nemerson 2010-11-20 06:34:19 UTC 
Created attachment 174901 [details] [review]
Include C header information in GIR
Comment 2 André Klapper 2011-06-23 22:05:13 UTC 
[Mass-reassigning open atk bug reports for better trackability as requested in https://bugzilla.gnome.org/show_bug.cgi?id=653179 .
PLEASE NOTE:
If you have watched the previous assignee of this bug report as a workaround for actually getting notified of changes in atk bugs, you yourself will now have to add atk-maint@gnome.bugs to your watchlist at the bottom of https://bugzilla.gnome.org/userprefs.cgi?tab=email to keep watching atk bug reports in GNOME Bugzilla.
Sorry for the noise: Feel free to filter for this comment in order to mass-delete the triggered bugmail.]
Comment 3 Jürg Billeter 2012-06-26 06:48:57 UTC 
Created attachment 217263 [details] [review]
Updated patch

I've updated the trivial patch. Ok to push?
Comment 4 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-06-26 09:28:02 UTC 
(In reply to comment #3)

> I've updated the trivial patch. Ok to push?

Yes. BTW, how important is include this bug on the release? This week is GNOME 3.5.3 release week. I already made an ATK release yesterday, so if possible I would prefer to include this patch on the next release (so not doing a release only for a patch).
Comment 5 Jürg Billeter 2012-07-18 15:43:44 UTC 
I appear to have missed the last comment. Pushed now.

(In reply to comment #4)
> Yes. BTW, how important is include this bug on the release? This week is GNOME
> 3.5.3 release week. I already made an ATK release yesterday, so if possible I
> would prefer to include this patch on the next release (so not doing a release
> only for a patch).

It's not urgent at all. We can work around the issue in Vala, but we want to be able to remove the workaround at some point.

commit ce7091ac833d1cd521dee0f926454ff03ab06776
Author: Evan Nemerson <evan@coeus-group.com>
Date:   Fri Nov 19 22:32:01 2010 -0800

    Include C header information in GIR
    
    Bug #635332.
Comment 6 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-07-18 15:50:32 UTC 
(In reply to comment #5)
> I appear to have missed the last comment. Pushed now.

A pity as I made an ATK release this Monday.

It will be included on next ATK release. Looking at schedule:

https://live.gnome.org/ThreePointFive

will be included on atk 2.5.5, to be created in august.

Thanks for the patch