GNOME Bugzilla – Bug 635244
pygi-convert.sh should cover buttons and message type constants
Last modified: 2010-11-19 17:41:03 UTC
Current version doesn't convert GtkMessageDialog flags: Gtk.MESSAGE_* -> Gtk.MessageType.*, and Gtk.BUTTONS_* -> Gtk.ButtonsType.*.
Created attachment 174823 [details] [review] convert message and buttons types OK for me to push?
Created attachment 174825 [details] [review] specify files on command line Would you consider applying this patch as well? It makes it much easier to use pygi-convert.sh for other projects without having to edit the script.
(In reply to comment #2) > Created an attachment (id=174825) [details] [review] > specify files on command line > > Would you consider applying this patch as well? It makes it much easier to use > pygi-convert.sh for other projects without having to edit the script. I'd just remove the sugar specific files and let Tomeu do that himself outside of the script.
Comment on attachment 174823 [details] [review] convert message and buttons types This looks good. Thanks
Comment on attachment 174823 [details] [review] convert message and buttons types Thanks, pushed the buttons/message type patch. I didn't push the second patch yet, as there were some concerns from Johan.
I think he was saying just remove the sugar specific stuff and make it generic.
Created attachment 174861 [details] [review] Remove sugar specifics, specify files on command line OK, this is a more generic one.
Created attachment 174863 [details] [review] convert pynotify to Notify GIR Shamelessly abusing this bug for another patch review. libnotify got a proper GIR yesterday, this will help with the conversion.
Both pushed, thanks!