Bug 634305 – Crash on move of contacts between books

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 634305 - Crash on move of contacts between books


Summary:	Crash on move of contacts between books


Status:	RESOLVED FIXED

Product:	evolution
Classification:	Applications
Component:	Contacts
Version:	2.30.x (obsolete)
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Milan Crha
QA Contact:	Evolution QA team

URL:
Whiteboard:

Duplicates:	634890 642338 647139 649872 649876 (view as bug list)
Depends on:
Blocks:

Reported:	2010-11-08 10:50 UTC by Pietro Battiston
Modified:	2011-09-23 13:50 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
evo patch (1.69 KB, patch) 2011-01-11 12:56 UTC, Milan Crha	committed	Details \| Review

Description Pietro Battiston 2010-11-08 10:50:07 UTC

If I take some contacts from a (local) addressbook and drag them to another addressbook, they are transferred (and for instance I am asked if I want to cancel/add/merge duplicates), then evolution crashes. Every time.

Here's a backtrace, I can provide any other required debug information:

+ Trace 224568

#0 IA__g_object_ref
at /scratch/build-area/glib2.0-2.24.2/gobject/gobject.c line 2396
#1 eab_merging_book_add_contact
at eab-contact-merging.c line 542
#2 final_id_cb
at eab-contact-merging.c line 118
#3 response
at eab-contact-merging.c line 447
#4 IA__g_closure_invoke
at /scratch/build-area/glib2.0-2.24.2/gobject/gclosure.c line 767
#5 signal_emit_unlocked_R
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 3248
#6 IA__g_signal_emit_valist
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 2981
#7 IA__g_signal_emit
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 3038
#8 IA__g_closure_invoke
at /scratch/build-area/glib2.0-2.24.2/gobject/gclosure.c line 767
#9 signal_emit_unlocked_R
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 3248
#10 IA__g_signal_emit_valist
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 2981
#11 IA__g_signal_emit
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 3038
#12 gtk_real_button_released
at /scratch/build-area/gtk+2.0-2.20.1/gtk/gtkbutton.c line 1725
#13 IA__g_closure_invoke
at /scratch/build-area/glib2.0-2.24.2/gobject/gclosure.c line 767
#14 signal_emit_unlocked_R
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 3178
#15 IA__g_signal_emit_valist
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 2981
#16 IA__g_signal_emit
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 3038
#17 gtk_button_button_release
at /scratch/build-area/gtk+2.0-2.20.1/gtk/gtkbutton.c line 1617
#18 _gtk_marshal_BOOLEAN__BOXED
at /scratch/build-area/gtk+2.0-2.20.1/gtk/gtkmarshalers.c line 84
#19 IA__g_closure_invoke
at /scratch/build-area/glib2.0-2.24.2/gobject/gclosure.c line 767
#20 signal_emit_unlocked_R
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 3286
#21 IA__g_signal_emit_valist
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 2991
#22 IA__g_signal_emit
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 3038
#23 gtk_widget_event_internal
at /scratch/build-area/gtk+2.0-2.20.1/gtk/gtkwidget.c line 4943
#24 IA__gtk_propagate_event
at /scratch/build-area/gtk+2.0-2.20.1/gtk/gtkmain.c line 2442
#25 IA__gtk_main_do_event
at /scratch/build-area/gtk+2.0-2.20.1/gtk/gtkmain.c line 1647
#26 gdk_event_dispatch
at /scratch/build-area/gtk+2.0-2.20.1/gdk/x11/gdkevents-x11.c line 2372
#27 g_main_dispatch
at /scratch/build-area/glib2.0-2.24.2/glib/gmain.c line 1960
#28 IA__g_main_context_dispatch
at /scratch/build-area/glib2.0-2.24.2/glib/gmain.c line 2513
#29 g_main_context_iterate
at /scratch/build-area/glib2.0-2.24.2/glib/gmain.c line 2591
#30 IA__g_main_loop_run
at /scratch/build-area/glib2.0-2.24.2/glib/gmain.c line 2799
#31 IA__gtk_main
at /scratch/build-area/gtk+2.0-2.20.1/gtk/gtkmain.c line 1219
#32 main
at main.c line 639

Comment 1 Pietro Battiston 2010-11-08 10:50:36 UTC

(by the way, the other addressbook is local too)

Comment 2 Akhil Laddha 2010-11-08 11:02:31 UTC

cann't reproduce in actual master (2.91.2)

Comment 3 Pietro Battiston 2010-11-08 12:32:49 UTC

Same circumstances, same behaviour, but sensibly different backtrace:

+ Trace 224569

#0 magazine_chain_pop_head
at /scratch/build-area/glib2.0-2.24.2/glib/gslice.c line 486
#1 thread_memory_magazine1_alloc
at /scratch/build-area/glib2.0-2.24.2/glib/gslice.c line 789
#2 IA__g_slice_alloc
at /scratch/build-area/glib2.0-2.24.2/glib/gslice.c line 827
#3 IA__g_slice_alloc0
at /scratch/build-area/glib2.0-2.24.2/glib/gslice.c line 845
#4 IA__g_signal_emit_valist
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 2946
#5 IA__g_signal_emit_by_name
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 3075
#6 e_minicard_label_event
at e-minicard-label.c line 379
#7 gnome_canvas_marshal_BOOLEAN__BOXED
from /usr/lib/libgnomecanvas-2.so.0
#8 IA__g_closure_invoke
at /scratch/build-area/glib2.0-2.24.2/gobject/gclosure.c line 767
#9 signal_emit_unlocked_R
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 3286
#10 IA__g_signal_emit_valist
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 2991
#11 IA__g_signal_emit
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 3038
#12 ??
from /usr/lib/libgnomecanvas-2.so.0
#13 _gtk_marshal_BOOLEAN__BOXED
at /scratch/build-area/gtk+2.0-2.20.1/gtk/gtkmarshalers.c line 84
#14 IA__g_closure_invoke
at /scratch/build-area/glib2.0-2.24.2/gobject/gclosure.c line 767
#15 signal_emit_unlocked_R
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 3286
#16 IA__g_signal_emit_valist
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 2991
#17 IA__g_signal_emit
at /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c line 3038
#18 gtk_widget_event_internal
at /scratch/build-area/gtk+2.0-2.20.1/gtk/gtkwidget.c line 4943
#19 IA__gtk_propagate_event
at /scratch/build-area/gtk+2.0-2.20.1/gtk/gtkmain.c line 2442
#20 IA__gtk_main_do_event
at /scratch/build-area/gtk+2.0-2.20.1/gtk/gtkmain.c line 1647
#21 gdk_event_dispatch
at /scratch/build-area/gtk+2.0-2.20.1/gdk/x11/gdkevents-x11.c line 2372
#22 g_main_dispatch
at /scratch/build-area/glib2.0-2.24.2/glib/gmain.c line 1960
#23 IA__g_main_context_dispatch
at /scratch/build-area/glib2.0-2.24.2/glib/gmain.c line 2513
#24 g_main_context_iterate
at /scratch/build-area/glib2.0-2.24.2/glib/gmain.c line 2591
#25 IA__g_main_loop_run
at /scratch/build-area/glib2.0-2.24.2/glib/gmain.c line 2799
#26 IA__gtk_main
at /scratch/build-area/gtk+2.0-2.20.1/gtk/gtkmain.c line 1219
#27 main
at main.c line 639

Comment 4 Milan Crha 2011-01-11 08:34:22 UTC

Downstream bug report from 2.32.1:
https://bugzilla.redhat.com/show_bug.cgi?id=668537

Steps:
1. Import a list of contacts from yahoo (by a vcard file)
2. Create a contact list "Professionnel"
3. Use drag'n'drop to move some contact from "Personnel" to "Professionnel"

+ Trace 225482

Thread 1 (Thread 3982)

#0 g_object_ref
at gobject.c line 2597
#1 eab_merging_book_add_contact
at eab-contact-merging.c line 558
#2 final_id_cb
at eab-contact-merging.c line 118
#3 add_contact_reply
at e-book.c line 439
#4 reply_cb
at gdbusproxy.c line 2163

Comment 5 Milan Crha 2011-01-11 12:56:30 UTC

Created attachment 178027 [details] [review]
evo patch

for evolution;

The merge context was freed before the code was done with it, causing the crash. It was doing that when moving more than one contact between two addressbooks.

Comment 6 Milan Crha 2011-01-11 13:00:12 UTC

Created commit 098a7ab in evo master (2.91.6+)

Comment 7 Milan Crha 2011-03-01 10:32:25 UTC

*** Bug 642338 has been marked as a duplicate of this bug. ***

Comment 8 Akhil Laddha 2011-05-10 10:17:41 UTC

*** Bug 649876 has been marked as a duplicate of this bug. ***

Comment 9 Akhil Laddha 2011-05-10 10:17:47 UTC

*** Bug 649872 has been marked as a duplicate of this bug. ***

Comment 10 Akhil Laddha 2011-07-07 04:24:16 UTC

*** Bug 647139 has been marked as a duplicate of this bug. ***

Comment 11 Milan Crha 2011-09-23 13:50:28 UTC

*** Bug 634890 has been marked as a duplicate of this bug. ***