Created attachment 169244 [details] [review]
videotestsrc: add moving color bars pattern

Any chance you could make a patch without unrelated style/indentation fixes?

(Please don't run gst-indent on header files, in case that's what caused these)

Created attachment 169252 [details] [review]
videotestsrc: add moving color bars pattern

This pattern is moving the color bars with a given
speed. Negative speed is inverting the moving direction.

Indeed, updated without gst-indent on header files...

What is this pattern meant to test?

You can get a similar effect using 'videotestsrc pattern=zone-plate kx=10 kt=-10'

(In reply to comment #5)
> What is this pattern meant to test?

This pattern is used here to test display controllers, displays and projectors. And can reveal different types of bugs.

> You can get a similar effect using 'videotestsrc pattern=zone-plate kx=10
> kt=-10'

well, it's similar in the way that it moves. The rest of the characteristics of the pattern look pretty different...

(In reply to comment #6)
> This pattern is used here to test display controllers, displays and projectors.
> And can reveal different types of bugs.

That's not very specific.

In any case, I would prefer to see horizontal/vertical speed added as a property to all the patterns (or rather, all the patterns where it's easy or useful), rather than add a new pattern.

As a side note, in the near future, I'm planning to convert all the pattern painting to work on a single AYUV/ARGB scanline, and then have a separate conversion to the final format.  Among other things, this would make scrolling patterns a nearly trivial offset adjustment between painting and conversion.

Review of attachment 169252 [details] [review]:

Scrolling speed should work with all patterns.

"moving-speed" should be "horizontal-speed".

The new pattern should be called smpte100.

Created attachment 169545 [details] [review]
updated patch

Fix conflicts that were caused by me hacking on videotestsrc today.

(In reply to comment #7)
> (In reply to comment #6)
> > This pattern is used here to test display controllers, displays and projectors.
> > And can reveal different types of bugs.
> 
> That's not very specific.

We use it to test synchronization, stitching, content/frame/genlock, ...
(sharp borders of the pattern are needed for this)

I will split it in parts:
- add spte100 pattern
- add horizontal-speed property
- implement horizontal-speed for spte100

On request here they also use a test-pattern with a white moving bar (on black background), are you interested in this? or can this already be done with a different pattern.

(In reply to comment #10)
> We use it to test synchronization, stitching, content/frame/genlock, ...
> (sharp borders of the pattern are needed for this)

Ok, thanks.  That makes more sense.

> On request here they also use a test-pattern with a white moving bar (on black
> background), are you interested in this? or can this already be done with a
> different pattern.

Adding this sounds like a good idea.  Should be foreground over background color, though, which defaults to white/black.

This patch is now on my list of things to push, once I've done some more testing.

And has now been pushed.