After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627692 - Report options, Account Selection, "select all" => not all accounts selected, only visible ones
Report options, Account Selection, "select all" => not all accounts selected,...
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: User Interface General
2.3.x
Other All
: Normal minor
: ---
Assigned To: gnucash-ui-maint
gnucash-ui-maint
Depends on:
Blocks:
 
 
Reported: 2010-08-23 06:09 UTC by Jannick
Modified: 2018-06-29 22:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Option "Select all" => not all accounts selected (76.14 KB, image/jpeg)
2010-08-23 06:09 UTC, Jannick
  Details
Account dialog: expand all in treeview before selecting "all" items (1.04 KB, patch)
2015-05-20 17:20 UTC, Stefan Söffing
committed Details | Review

Description Jannick 2010-08-23 06:09:12 UTC
Created attachment 168542 [details]
Option "Select all" => not all accounts selected

"Select all" in the the options of the transaction report selects the VISIBLE accounts only, not those whose parent account is closed, hence invisible, in the account list.

In the attached an example:
- open account "revenues"
- close account "expenses"
- choose "select all"
- open account "expenses"
=> account "transaction cost" - child of "expenses" not (!) selected 

gtk-version 2.16.6 (info by Christian)
Comment 1 Christian Stimming 2010-08-23 08:18:52 UTC
We need to check whether this is still a problem with newer gtk versions (2.18.x) and/or on Linux. On Windows gnucash is currently forced to use this relatively old versions due to some more severe problems with the newer ones.
Comment 2 Christian Stimming 2010-09-04 21:08:34 UTC
Gtk-2.20.1 (on Linux) behaves the same. So it is GTK's default behaviour and you (or we) would need to discuss with GTK to change this behaviour. I'm afraid this doesn't happen unless you file this as a GTK bug yourself.
Comment 3 Stefan Söffing 2015-05-20 17:20:33 UTC
Created attachment 303689 [details] [review]
Account dialog: expand all in treeview before selecting "all" items

Guys,

I haven't done much programming for a few years, however, this bug was annoying to me and seemed simple enough as a start. Please review and commit this patch, it simply expands all collapsed items in the tree view so that the subsequent call to select_all really selects all accounts, not only the visible ones.

Please note that this also partially fixes Bug 639538.
Comment 4 Mike Evans 2015-05-21 10:14:37 UTC
Review of attachment 303689 [details] [review]:

Works on Fedora 18 on maint branch.  I can't test on master, Fedora too old.
Comment 5 Geert Janssens 2015-10-10 13:19:59 UTC
Review of attachment 303689 [details] [review]:

Oops, for some reason this patch managed to go unnoticed for me.

That's a fine solution for an annoying problem, so I have committed this to maint. It will appear in the next stable gnucash release (2.6.10).

Thank you very much for your patch and again my apologies for the long delay in getting it merged.
Comment 6 Geert Janssens 2015-10-10 13:20:17 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.
Comment 7 John Ralls 2018-06-29 22:43:35 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=627692. Please update any external references or bookmarks.