After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 617735 - Add Functionality to open image always in same window
Add Functionality to open image always in same window
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
git master
Other Linux
: Normal enhancement
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-05 09:49 UTC by liganic
Modified: 2011-10-07 15:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
git diff patch for single window viewing (3.59 KB, patch)
2010-05-05 09:49 UTC, liganic
none Details | Review
revision 2 of the patch for single window viewing (3.71 KB, patch)
2011-08-25 18:21 UTC, liganic
reviewed Details | Review
formatted git commit of the patch (4.18 KB, patch)
2011-10-06 16:03 UTC, liganic
none Details | Review

Description liganic 2010-05-05 09:49:15 UTC
Created attachment 160328 [details] [review]
git diff patch for single window viewing

This adds the functionality which was expected in bug 555008. Also referenced in https://bugs.launchpad.net/ubuntu/+source/eog/+bug/278107

The patch adds the -s / --single-window command line parameter. If specified, the images get opened in the same window instead of opening a new window. If there are multiple windows open, the first one is chosen.
Comment 1 Robert Roth 2011-02-23 13:32:52 UTC
This should be marked as a duplicate of https://bugzilla.gnome.org/show_bug.cgi?id=556286 as it describes the same problem, and provides a patch for it.
Comment 2 liganic 2011-08-25 18:21:21 UTC
Created attachment 194732 [details] [review]
revision 2 of the patch for single window viewing

I changed (and fixed) the patch so it now works with the current HEAD (655e57e45787594dbb0bb791159cf9f3c9ba5335).
Comment 3 Felix Riemann 2011-09-29 15:12:23 UTC
Review of attachment 194732 [details] [review]:

While this is not exactly what is requested in bug 555008 it's on the way to it.

Can you provide us with a git commit-diff (git format-patch) with your full name and email set?
We need this to check it into our git.
Comment 4 liganic 2011-10-06 16:03:40 UTC
Created attachment 198445 [details] [review]
formatted git commit of the patch
Comment 5 Felix Riemann 2011-10-07 15:07:19 UTC
Thanks. Modified the commit message to match the style we use.

commit 45ed40ecb15a1db97ad34752a237d187b2aec34c
Author: Michael Wünsch <>
Date:   Thu Oct 6 17:56:16 2011 +0200

    Allow reusing an existing window for another image from the commandline
    
    Reuses an existing window instead of opening a new one.
    For now this is only supported from the commandline.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=617735

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.