GNOME Bugzilla – Bug 616603
Should use tp-glib API to get avatar requirements
Last modified: 2011-08-29 10:12:37 UTC
Next version of tp-glib should provide API to get avatar requirements from a TpConnection, so we can drop our code in EmpathyTpContactFactory. Patch: http://git.collabora.co.uk/?p=user/xclaesse/empathy.git;a=shortlog;h=refs/heads/avatar-req
Please log a DEBUG message if proxy_prepare failed and if tp_connection_get_avatar_requirements returned NULL. + tp_proxy_prepare_async ((TpProxy *) priv->connection, No need to cast, this function takes a gpointer. You should have split this branch into 2 commits: - Make use of TP_CONNECTION_FEATURE_AVATAR_REQUIREMENTS (and put the bug number in the commit msg) - Remove the old code in the factory. Note that we have to wait that tp-glib 0.11.4 has been released and Empathy can depend on it before merging this.
(In reply to comment #1) > Please log a DEBUG message if proxy_prepare failed no need, tp-glib already log the error. > and if tp_connection_get_avatar_requirements returned NULL. done > + tp_proxy_prepare_async ((TpProxy *) priv->connection, > No need to cast, this function takes a gpointer. done > You should have split this branch into 2 commits: > - Make use of TP_CONNECTION_FEATURE_AVATAR_REQUIREMENTS (and put the bug number > in the commit msg) > - Remove the old code in the factory. done > Note that we have to wait that tp-glib 0.11.4 has been released and Empathy can > depend on it before merging this. upgraded dep now that it's released I also added a not related trivial patch to remove usage of factory to publish location.
Looks good. We'll merge once Empathy is allowed to depend on tp-glib 0.11.4 (I may skip this one and wait for 0.11.5 though). Feel free to merge the third patch now if you want.
Please merge.
merged, thanks.