After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615331 - [Regression] Message list/Folder tree focus policy has changed
[Regression] Message list/Folder tree focus policy has changed
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.30.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2010-04-09 21:30 UTC by David Ronis
Modified: 2010-04-19 17:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Attachments
evo patch (5.34 KB, patch)
2010-04-19 10:27 UTC, Milan Crha
committed Details | Review

Description David Ronis 2010-04-09 21:30:23 UTC
I often switch to a folder, select all the entries in the message list (via ctrl-a) and delete them.  In last night's git/master the focus policy seems to have changed; namely, I now have to explicitly click on one of the list entries before ctrl-a will work.   

To be sure, I've configured metacity to use click-to-focus for windows, etc., but I'd like to use at "sloppy" focus here.  I think the old behavior was even more general.

From what I can tell there is no evolution-specific focus setting that would override metacity's, but it seems that that would be a reasonable way to allow the user to choose between a strict adherence to the desktop global policy and something less restrictive.
Comment 1 Matthew Barnes 2010-04-09 21:44:16 UTC
Looks like it was caused by the patch for bug #612236.
Comment 2 Milan Crha 2010-04-19 09:33:40 UTC
Yes, I caused this with my change to bug #612236. The explicit focus move to message list causes issues.

I would say that the EFocusTracker in a mailer view should be less restrictive, and behave same with a folder tree and a message list selected. I'll try to cook a patch for it. Note that other hot-keys are working as expected, for example Ctrl+[ / Ctrl+], regardless I stay at the folder tree or the message list.
Comment 3 Milan Crha 2010-04-19 10:27:08 UTC
Created attachment 159055 [details] [review]
evo patch

for evolution;

Not many options here, seems to me. Either something like this or nothing. I'm committing to master and stable.
Comment 4 Milan Crha 2010-04-19 10:39:18 UTC
Created commit 5974489 in evo master (2.31.1+)
Created commit 7841714 in evo gnome-2-30 (2.30.1+)
Comment 5 Matthew Barnes 2010-04-19 12:14:28 UTC
I was going to suggest having the folder tree pass any unhandled key presses to the message list, but I think I like your approach better.  Very clever.
Comment 6 David Ronis 2010-04-19 17:51:56 UTC
Thanks Milan,

It's fixed.