GNOME Bugzilla – Bug 614451
Embed page setup dialog in the print dialog
Last modified: 2010-11-23 16:16:32 UTC
Created attachment 157572 [details] [review] patch embedding page setup in the print dialog There is a possibility of embedding paper size combo and orientation combo in the print dialog since Gtk+ 2.17.4. It is activated by calling of gtk_print_operation_set_embed_page_setup() function. It would be nice to have this feature in eog. Regards Marek
Review of attachment 157572 [details] [review]: Patch looks good to me so far. :) One problem though: (eog:24499): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed I get this after changing the paper size and then printing to it the first time. Seems like the page setup object has a problem with the object lifetime.
Created attachment 157751 [details] [review] patch embedding page setup in the print dialog Hi Felix, this is modified version of the previous patch. Function eog_print_image_setup_update unreferenced given "page_setup" which was not correct. Thanks for catching this Marek
Comment on attachment 157751 [details] [review] patch embedding page setup in the print dialog Thanks Marek. Just pushed this one to the repo. commit cffc41e7b0f255cdaf82052dad83ff1539599fdb Author: Marek Kasik <> Date: Fri Apr 2 15:00:26 2010 +0200 Embed page setup in the print dialog This patch activates paper size combo and orientation combo in the Page Setup tab in the print dialog. It removes "Page Setup..." from the file menu. It also actualize paper size in Image Settings each time it changes. (bug 614451)
*** Bug 628492 has been marked as a duplicate of this bug. ***
Reported this problem also to other GTK-based programs: f-spot: https://bugzilla.gnome.org/show_bug.cgi?id=635611 GIMP: https://bugzilla.gnome.org/show_bug.cgi?id=635615 shotwell: http://trac.yorba.org/ticket/2733