GNOME Bugzilla – Bug 605834
directsoundsink: 16-bit audio is always signed while 8-bit is always unsigned
Last modified: 2011-07-09 23:47:17 UTC
Created attachment 150627 [details] modify caps to match what DirectSound always uses pretending to handle 8-bit signed causes distorted audio when actually given such audio, which you will get if passing 8-bit unsigned through audioconvert ! audioresample, as audioresample only handles 8-bit signed. By the way, since this is taken directly from http://sourcecode.opera.com/gstreamer/gst-plugins-good.git/ please tell me if there's a more straightforward way of submitting patches that avoid the "diff" roundtrip and will save you the trouble of writing a new commit message when I have already done so.
git format-patch -N - dumps last N commits as patches
It seems to be already fixed here: https://delta.affinix.com/svn/trunk/psimedia/gstprovider/gstelements/directsound/ see bug: https://bugzilla.gnome.org/show_bug.cgi?id=584980
What should happen with this bug now? Is there a new, git format-patch style patch? Is this still needed at all?
Philip, would you please respond to comment#3 ?
Created attachment 191440 [details] [review] redone with git format-patch
We're still shipping Opera with this patch applies. Unless there have been changes elsewhere to filter the caps (highly unlikely) it is still needed.
commit fbe726c3da9bb8e46291c1186a11e53866f14a9e Author: Philip Jägenstedt <philipj@opera.com> Date: Fri Nov 20 10:07:43 2009 +0100 directsoundsink: 16-bit audio is signed, 8-bit is unsigned. Pretending to handle 8-bit signed causes distorted audio when actually given such audio, which you will get if passing 8-bit unsigned through audioconvert ! audioresample, as audioresample only handles 8-bit signed. Fixes #605834. Signed-off-by: David Schleef <ds@schleef.org>