GNOME Bugzilla – Bug 605498
General tab: strings are unecessarily complex
Last modified: 2016-09-08 12:45:41 UTC
Created attachment 150423 [details] Analysis of the general tab. There are a number of issues with the strings in the general tab of gnome-keyboard-properties: * They are repetitious ('key*' is repeated three times, 'repeat' twice, etc). * 'text fields' is an overly technical term. * 'Cursor blinks in text fields' is in the present continuous tense, which is non-standard practice. * The sub-headings are unnecessary. Together, these issues mean that the dialog is unnecessarily complex. There is more text than is necessary. There are more visual elements than are required. Possible alternations which would address these issues are: * Remove the headings. * Change the label of the first checkbox to 'Repeat action when key is held down' - this is clear and simple. * Change the label of the second checkbox to 'Blink text cursor' - this is also clear and simple, in the right tense, and avoids technical language. This bug is part of the design review that can be found on the usability whiteboard [1]. An analysis of the general tab is attached. A mockup of the proposed changes can be found on the whiteboard page. [1] http://live.gnome.org/UsabilityProject/Whiteboard/KeyboardPreferences
Created attachment 156083 [details] [review] Updated gnome-keyboard-properties-dialog.ui
Hello. I have made patch to add changes in general tab. I have remade whole general tab in gnome-keyboard-properties-dialog.ui via glade3 plus I have added necessary code to gnome-keyboard-properties.c to work normal way.
Hi Anton! Thanks for your patch. It's great to have your contribution. Can someone review this?
Review of attachment 156083 [details] [review]: Since we're currently in freeze, the full review will have to wait for a bit. Some immediately obvious tidbits follow. Also, as a general advice, some screenshots (ideally directly comparing old and new layout) usually help getting reviews more quickly since it's much less work if you don't have to go through the code to see the changes in action. ::: capplets/keyboard/gnome-keyboard-properties.c @@ +125,3 @@ gchar *monitor; + /* Maybe some chinese code but look more pretty */ Huh? @@ +129,3 @@ (changeset, "/desktop/gnome/peripherals/keyboard/repeat", WID ("repeat_toggle"), NULL); + /* Repeat delay label */ Identation is broken all through the following changes.
Created attachment 200215 [details] [review] Patch to update the layout Patch against the latest trunk to update the keyboard panel based on the mockup from https://live.gnome.org/UsabilityProject/Whiteboard/KeyboardPreferences.
Created attachment 200216 [details] Screenshot of the patched panel Screenshot showing the keyboard panel before the changes and after the changes.
The mockup is 1.5 years old, and doesn't reflect what we actually want the panel to look like. The latest mockup is: https://live.gnome.org/Design/SystemSettings/Keyboard See also bug 643486
Review of attachment 200215 [details] [review]: This has been implemented based on an obsolete mockup, rejecting based on comment 7.
Those problems are fixed in the new Keyboard panel in GNOME 3.22.