After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602174 - Avoid using accel group internals in GtkWindow
Avoid using accel group internals in GtkWindow
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.90.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-11-17 08:41 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-09-08 23:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Move GtkAccelGroup private structure to shared header file (2.46 KB, patch)
2009-11-30 03:49 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Move GtkAccelGroup private structure to shared header file.v2 (4.14 KB, patch)
2009-11-30 03:57 UTC, Javier Jardón (IRC: jjardon) 		reviewed Details | Review
Move GtkAccelGroup private structure to shared header file.v3 (4.16 KB, patch)
2009-11-30 18:46 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-11-17 08:41:17 UTC 
+++ This bug was initially created as a clone of Bug #599403 +++

In the 2.90 branch GtkAccelGroup's structure fields were removed, so GtkWindow
doesn't compile anymore. I wonder if we can fix this without access to these
members.
Comment 1 Javier Jardón (IRC: jjardon) 2009-11-30 03:49:58 UTC 
Created attachment 148715 [details] [review]
Move GtkAccelGroup private structure to shared header file

Here a patch to solve this problem using a private structure stored in a shared header file.
If this is the correct approach, GtkAccelLabel and gailmenuitem.c have the same problem.
Comment 2 Javier Jardón (IRC: jjardon) 2009-11-30 03:57:41 UTC 
Created attachment 148716 [details] [review]
Move GtkAccelGroup private structure to shared header file.v2

Sorry, I forgot to add the new file
Comment 3 Christian Dywan 2009-11-30 14:12:28 UTC 
Review of attachment 148716 [details] [review]:

Looks like the right thing to do. You may want to keep GTK_ACCEL_GROUP_GET_PRIVATE inside gtkaccelgroup.c to make sure nobody is tempted to use it, other than that go for it.
Comment 4 Javier Jardón (IRC: jjardon) 2009-11-30 18:46:40 UTC 
Created attachment 148773 [details] [review]
Move GtkAccelGroup private structure to shared header file.v3
Comment 5 Javier Jardón (IRC: jjardon) 2009-11-30 19:38:45 UTC 
Comment on attachment 148773 [details] [review]
Move GtkAccelGroup private structure to shared header file.v3

commit 715056f7348b51f3a3a9b3812afabcc45155b135