GNOME Bugzilla – Bug 601538
With "Stop after song" enabled, the same song shouldn't play twice in a row
Last modified: 2020-03-17 08:24:32 UTC
Bug 563021, Comment 13 led to this bug report. The issue is that when you have "stop after current song" enabled, the selection doesn't move when the song finishes, so if you come back to your music later and press the Play button, Banshee replays the song that you most recently played. This is especially noticeable when using "stop after..." with the Play Queue. The logical way to fix this would be to advance the selection to the song that will play next once the "stop after..." song finishes. This behavior has the potential to be quite annoying if you're listening to your music library on shuffle. Fixing this only in the Play Queue would make the queue's behavior seem more natural, but it would make the "stop after..." action inconsistent with the rest of Banshee. I think this should at least be changed in the Play Queue. This issue seems more noticeable with the queue than with other sources, and I doubt many users would care about - or even notice - the inconsistency this causes with the rest of Banshee. There might be more graceful solutions to this issue, but I can't think of them right now.
*** Bug 607537 has been marked as a duplicate of this bug. ***
I posted a comment about this on banshee-list (09/05/2010 09:57 AM) when I was using 1.6.1 and was told a short while later that it appeared to be fixed in 1.7.5. However, I've just upgraded to 1.8.0 and can confirm that the problem is still there. Also, this bug is classified as an "enhancement", but it really seems that the current behavior is buggy -- but maybe I'm just misunderstanding the scope of the term "enhancement". Speaking of enhancements, though, I'd also like to draw attention to a few other enhancement requests related to the same functionality that have been made: * Bug 549173, which asks for a menu item in the tray icon pop-up to enable Stop when Finished, and for which there appears to have been a patch available since February 2009, * Bug 552017, which suggests that Shift+Click on the Pause button enable Stop when Finished, * Bug 585072 (and Bug 552017, Comment 4), which suggests a track context menu item to allow stopping after future songs are finished, and finally * Bug 628132, which requests a prominent indicator that Stop when Finished is currently enabled. (I apologize if such cross-referencing between bugs is discouraged.)
Thinking about this a bit more, on the Play Queue side, wouldn't it be as simple as removing the selection from the currently playing song when playback stops? That way no track will be selected, and Banshee should start playback with the first song in the queue instead of the song that just played. But maybe I'm under-thinking this...
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.