After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 601497 - FTBFS on the Hurd: PATH_MAX undefined
FTBFS on the Hurd: PATH_MAX undefined
Status: RESOLVED OBSOLETE
Product: gvfs
Classification: Core
Component: build
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
: 647667 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-11-11 09:21 UTC by Emilio Pozuelo Monfort
Modified: 2018-05-04 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the build on the Hurd (2.96 KB, patch)
2009-11-11 09:24 UTC, Emilio Pozuelo Monfort 		none Details | Review
Updated patch that applies on top of 1.8.0 (3.02 KB, patch)
2011-04-13 15:04 UTC, Raphael Hertzog 		none Details | Review

Description Emilio Pozuelo Monfort 2009-11-11 09:21:51 UTC 
[ From http://bugs.debian.org/555055 ]

gvfs currently FTBFS on hurd-i386 because of unconditional use of
PATH_MAX. The attached patch fixes it by just using glibc's ability to
allocate just what is required. It also actually fixes a bug for the
case when a symlink in /dev doesn't exist.
Comment 1 Emilio Pozuelo Monfort 2009-11-11 09:24:05 UTC 
Created attachment 147453 [details] [review]
Fix the build on the Hurd

Patch from Samuel Thibault <sthibault@debian.org> to fix the build on the GNU/Hurd and fix a bug in the error checking of realpath()
Comment 2 Raphael Hertzog 2011-04-13 14:55:09 UTC 
*** Bug 647667 has been marked as a duplicate of this bug. ***
Comment 3 Raphael Hertzog 2011-04-13 15:04:19 UTC 
Created attachment 185880 [details] [review]
Updated patch that applies on top of 1.8.0

Please consider applying this updated patch, note that it's not only hurd support that is achieved but there's also a bug fix because a test was inverted.
Comment 4 Raphael Hertzog 2011-04-13 15:05:17 UTC 
Note that you can drop the #ifdef (and what's in the #else/#endif) if you
assume/require POSIX.1-2008 compatibility.
Comment 5 Tomas Bzatek 2011-04-13 16:45:29 UTC 
Looking at the #ifdef __GLIBC__ tests, I wonder how does gvfs come along with other variants of standard C library.
Comment 6 Alexander Larsson 2011-04-15 12:49:08 UTC 
I'm commiting the bugfix, but I don't like the __GLIBC__ check. We should be
doing some form of autoconf check with a HAVE_DYNAMIC_REALPATH result, rather than hardcoding ifdefs for a particular library version (and its probably not even right, ancient glibc may not have that features).
Comment 7 Kjartan Maraas 2011-05-23 20:20:26 UTC 
Maybe close this and file a new bug for the autoconf check if the bugfix has gone in?
Comment 8 Ondrej Holy 2018-05-04 10:12:10 UTC 
This is an old bug and PATH_MAX is not currently used in the code, let's close as obsolete.