GNOME Bugzilla – Bug 599997
Add back support for "decrease size to fit screen size" for images
Last modified: 2018-03-30 16:25:15 UTC
See summary, Midori already does this with Webkit and epiphany did with gecko too. If this should be fixed in webkit instead: https://bugs.webkit.org/show_bug.cgi?id=29918
This is a setting, "auto-shrink-images" in WebKitGTK+, that we have set to FALSE and I guess Midori has set to TRUE, if I understand correctly what you are talking about. Does Midori show images shrinked by default allowing you to click to expand them?
Yes
Epiphany used to zoom 1:1 initially and allow to resize-to-screen on click. I'm in favor of re-implementing the old behavior.
(In reply to comment #3) > Epiphany used to zoom 1:1 initially and allow to resize-to-screen on click. I'm > in favor of re-implementing the old behavior. So you mean exactly the opposite behaviour to what Xan talked about in comment #2, don't you? That is, to show the original size by default and shrink if clicked only.
I've filed a new bug in WebKit asking for the required changes to get this bug fixed. Also, suggested there two proposals to fix it and attached patches for both of them. https://bugs.webkit.org/show_bug.cgi?id=32801 Depending on the proposal finally accepted (assuming of them would be accepted :-)) the patch for epiphany could be as simple as "do nothing" (no patch) or as adding a new hardcoded property,more or less this way (proposal 1): diff --git a/embed/ephy-embed-prefs.c b/embed/ephy-embed-prefs.c index a7cf60e..e032f0b 100644 --- a/embed/ephy-embed-prefs.c +++ b/embed/ephy-embed-prefs.c @@ -393,7 +393,8 @@ ephy_embed_prefs_init (void) /* Hardcoded settings */ g_object_set (settings, - "auto-shrink-images", FALSE, + "auto-shrink-images", TRUE, + "auto-shrink-images-initially", FALSE, "enable-default-context-menu", FALSE, NULL); Let's see how it evolves...
(In reply to comment #5) > I've filed a new bug in WebKit asking for the required changes to get this bug > fixed. Also, suggested there two proposals to fix it and attached patches for > both of them. > > https://bugs.webkit.org/show_bug.cgi?id=32801 Looks like I forgot to add the review? flags in WK bugzilla back in December, so the patches got overlooked :( Updated both of them against last trunk of WK and uploaded the new versions along with the review? flags. Hope we can get this fixed soon now... Sorry for me being so absentminded :/
Ping
This is a mass NEEDINFO of all Epiphany bugs with no activity in the past three years. I'm going to be automatically closing old bugs to help us focus on current problems. If you feel this bug is still relevant with Epiphany 3.26 or newer, then please leave any comment here so that I know not to close this one.
This is a mass-close of old bugs currently in the NEEDINFO state. If you think this bug is still relevant, please leave a comment.