GNOME Bugzilla – Bug 597124
Should make better use of libnotify actions
Last modified: 2011-08-29 10:12:37 UTC
Bug #589408 added a "Respond" button to all libnotify bubbles (when supported by the notifications daemon). This works fine with chat events but not really for others kinds of events. For example, if you receive a audio/video call event, clicks on the "Respond" button, the call isn't accepted; instead another dialog is displayed asking if we wants to accept or decline the call. The libnotify bubble should have a "Accept" and "Decline" buttons and display the dialog only if those buttons have not been pressed. Marking this as a blocker for 2.30 as that's an important UI issue.
Activating a notification does not accept anything. If the even needs an accept to join a chatroom, or accept an auth request, you'll get a dialog asking yes or no... If you activate an even, you just get the chat window, you can still just close it. On windows clicking the bubble activate the even AFAIK. The only reason empathy does not do that already, is because the needed API to know if it was closed because of timeout or because of user click was too recent in libnotify... and I made a crap #ifdef that obviously does not work...
I'm not convince that poping a chat window to the user when clicking on the bubble is the right things to do. Anyway, as said in this, we plan to add more specific buttons to the notifications depending on its type.
(In reply to comment #0) > The libnotify bubble should have a "Accept" and "Decline" buttons IMHO this is exactly what it should _not_ have... anyway, this seems like a thing that needs gnome-shell integration and should therefore be discussed with the gnome-shell designers for 3.0?
I agree with Michael. That feature should be integrated with gnome-shell, not just with the notifications bubbles, as for example ubuntu's notify-osd is not using actions on notifications (something that i like, btw). Just my 2 cents...
Currently 17 Empathy tickets are set as GNOME 2.30 blockers, hence mass-removing. Guillaume: Please use normal Target Milestones instead. If you really think that this specific issue here is a 2.30 blocker then please restore the GNOME target and set corresponding importance values.
*** Bug 610032 has been marked as a duplicate of this bug. ***
Created attachment 165355 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/notif-buttons-597124 src/empathy-event-manager.c | 31 +++++++++++++++++++- src/empathy-event-manager.h | 5 ++- src/empathy-status-icon.c | 65 +++++++++++++++++++++++++++++++++++------- 3 files changed, 87 insertions(+), 14 deletions(-)
Review of attachment 165355 [details] [review]: ++
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.