After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595731 - contact ID completion should work also for offline contacts
contact ID completion should work also for offline contacts
Status: RESOLVED DUPLICATE of bug 583919
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-09-20 08:36 UTC by Nicolò Chieffo
Modified: 2009-11-09 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
display-all.patch (1.92 KB, patch)
2009-10-01 15:56 UTC, Nicolò Chieffo 		none Details | Review

Description Nicolò Chieffo 2009-09-20 08:36:53 UTC 
Hello, I would like to ask you why the contact ID entry, (available in "chat->new conversation") has autocompletion enabled only for online contacts.
In my opinion, if the protocol supports offline messages, the autocompletion should be enabled also for offline contacts!
Comment 1 Nicolò Chieffo 2009-09-20 08:58:40 UTC 
I've had a look at the code, this is a really easy fix if someone knows how to detect if the protocol supports offline messages
Comment 2 Guillaume Desmottes 2009-10-01 15:14:17 UTC 
I agree. The spec doesn't give us this information atm, but I think we could always display all contacts.
Comment 3 Nicolò Chieffo 2009-10-01 15:56:02 UTC 
Created attachment 144513 [details] [review]
display-all.patch

I really appreciate your opinion.
Displaying all contacts is a matter of a very simple patch: just remove an if and reindent :)
Comment 4 Guillaume Desmottes 2009-11-09 12:40:40 UTC 
How this is already fixed actually. Thanks for the patch anyway :)

*** This bug has been marked as a duplicate of bug 583919 ***