After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595515 - a [GstXSink] base class would be nice
a [GstXSink] base class would be nice
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-17 21:06 UTC by Carl-Anton Ingmarsson
Modified: 2013-07-17 08:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Carl-Anton Ingmarsson 2009-09-17 21:06:45 UTC 
Atm. we have three sinks sharing nearly the exact code: ximagesink, xvimagesink and vdpausink. Therefore I think a baseclass that would take care of the common parts (window creation, event handling etc.) would be good to have.

The subclass would then implement a draw virtual function where it would put the incoming buffers on the screen.

I originally started on this when i wrote the vdpausink, but being lazy and all, I gave it up and took the easy route instead.
Comment 1 Sebastian Dröge (slomo) 2011-05-20 07:27:30 UTC 
Are you going to work on this, or is anybody else?
Comment 2 Edward Hervey 2013-07-17 06:29:26 UTC 
Is this still needed with the new 1.x meta system ?
Comment 3 Sebastian Dröge (slomo) 2013-07-17 08:03:46 UTC 
Completely independent of the metas IMHO. What is requested here is a base class that does the window creation (not useful, that's only a debugging feature anyway) and all the other X11 handling, like events.

I don't think this would be useful after all, as something like vdpausink will probably not only support X11 but also other window systems. And as such can't use this base class anyway.
Also the X11 specific code is not really complicated. Let's close this as WONTFIX unless someone really needs it and works on it.