After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592932 - Remove redundant version checks.
Remove redundant version checks.
Status: RESOLVED FIXED
Product: xchat-gnome
Classification: Other
Component: general
HEAD
Other Linux
: Normal trivial
: ---
Assigned To: xchat-gnome maintainers
xchat-gnome maintainers
: 614828 (view as bug list)
Depends on:
Blocks: 602311
 
 
Reported: 2009-08-24 17:57 UTC by Adam Buchbinder
Modified: 2010-04-07 06:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch against b62af064e848915c432529332dd0b7e23730a7c8 removing the redundant checks. (2.45 KB, patch)
2009-08-24 17:57 UTC, Adam Buchbinder 		none Details | Review
Patch removing the *correct* redundant checks. (3.25 KB, patch)
2010-03-24 18:59 UTC, Adam Buchbinder 		committed Details | Review

Description Adam Buchbinder 2009-08-24 17:57:30 UTC 
Created attachment 141580 [details] [review]
Patch against b62af064e848915c432529332dd0b7e23730a7c8 removing the redundant checks.

configure.ac requires glib >= 2.18.0 and gtk >= 2.14.0. However, there are
still checks in the code testing for earlier versions. Since the code doesn't
declare itself compatible with these earlier versions, the checks can be
removed.
Comment 1 Ritesh Khadgaray ( irc:ritz) 2009-09-11 20:16:39 UTC 
nice catch. commited

http://git.gnome.org/cgit/xchat-gnome/commit/?id=f725dac607f25b8f08e0abb2faaadd3fe878ef4f
Comment 2 Adam Buchbinder 2010-03-24 18:57:24 UTC 
Whoops; that patch deleted the wrong lines. The two patches in one file to be attached momentarily revert that one and delete the correct (pre-2.4.0) lines.
Comment 3 Adam Buchbinder 2010-03-24 18:59:57 UTC 
Created attachment 157010 [details] [review]
Patch removing the *correct* redundant checks.
Comment 4 Ritesh Khadgaray ( irc:ritz) 2010-04-07 06:11:35 UTC 
*** Bug 614828 has been marked as a duplicate of this bug. ***
Comment 5 Ritesh Khadgaray ( irc:ritz) 2010-04-07 06:18:47 UTC 
Review of attachment 157010 [details] [review]:

committed with minor modifications. We require gtk 2.14 and above to build xg.
Comment 6 Ritesh Khadgaray ( irc:ritz) 2010-04-07 06:24:53 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.