After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590741 - New windows appear unscaled
New windows appear unscaled
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 591051 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-08-04 14:58 UTC by Jonathan Blandford
Modified: 2009-08-10 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sshot (440.75 KB, image/png)
2009-08-04 14:58 UTC, Jonathan Blandford
  Details
Use the size of the window, not of the clone to position windows (1.90 KB, patch)
2009-08-08 04:52 UTC, Owen Taylor
none Details | Review

Description Jonathan Blandford 2009-08-04 14:58:33 UTC
New windows aren't appearing scaled in the overlay mode.  They are appearing full-size instead.   See attached screenshot for an example.
Comment 1 Jonathan Blandford 2009-08-04 14:58:58 UTC
Created attachment 139873 [details]
sshot
Comment 2 Colin Walters 2009-08-04 16:39:41 UTC
<jnettlet> augias: walters: I tracked down that window creation problem.  It was a mutter commit actually.
<jnettlet> more specifically the launching a new window in the overlay being enormous
<walters> ah, interesting
<jnettlet> git commit 1f90529365f38efdafc4b85be1c4a5e048b5573f
<walters> well, there is a possibly related bug where when the app monitoring fails we keep around a reference to a bad window
 which is fixed in bugzilla
 jnettlet: hmm, maybe we need to connect to notify::allocation in the workspaces?
<jnettlet> walters: I was thinking about doing something like that
<jnettlet> definitely a little cleaner than an idle loop
<tf> jnettlet, what's the issue with 1f90529365f38efdafc4b85be1c4a5e048b5573f ?
<jnettlet> tf: well I don't think anything other than it breaks some of the shell code
<tf> are you cloning the window ?
<jnettlet> yes
<tf> and putting into something like ClutterGroup ?
<walters> yeah
<jnettlet> yep
<tf> you need to set a size on the clone
<jnettlet> put I was using the clone to set the size :-(
<tf> or put it into a proper container, not ClutterGroup :)
<walters> jnettlet: yeah, so inside workspaces.js, connect to notify::allocation on the source, and sync the size
 also sync the size initially
 tf: yeah, a proper container would be good...we really need js gobject subclassing
<tf> sorry, I forgot
Comment 3 Marina Zhurakhinskaya 2009-08-07 18:32:31 UTC
*** Bug 591051 has been marked as a duplicate of this bug. ***
Comment 4 Owen Taylor 2009-08-08 04:52:31 UTC
Created attachment 140177 [details] [review]
Use the size of the window, not of the clone to position windows

When Workspace._positionWindows is called, the clone might nto
yet have its final size (because of the clone is is a clone of
the window texture and the window texture isn't updated until
right before painting.) So get the size from the MetaWindow
instead ... the MetaWindow size is determined synchronously when
the window is managed.
Comment 5 Owen Taylor 2009-08-10 13:55:30 UTC
Rebased to current master, added a comment, pushed.