After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 589409 - the Event struct in EmpathyEventManager should contain an enum with the event type
the Event struct in EmpathyEventManager should contain an enum with the event...
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
sjoerd[moblin]
Depends on:
Blocks:
 
 
Reported: 2009-07-22 17:15 UTC by Sjoerd Simons
Modified: 2010-09-20 14:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Code based on Jonathan's branch but, unfortunatelly, as the patches were badly recorded, I had to re-record it (6.29 KB, patch)
2009-10-02 14:29 UTC, Guillaume Desmottes
committed Details | Review

Description Sjoerd Simons 2009-07-22 17:15:24 UTC
To enable some functionality wrt. notifications it would be nice if the Event structure in the notification had a enum value to describe their type (incoming text channel, subscription, etc)
Comment 1 Guillaume Desmottes 2009-08-07 16:04:14 UTC
Good idea, that would allow a cleaner implementation of #580794
Comment 2 Jonathan Tellier 2009-08-14 13:14:39 UTC
In order to fix Bug 580794, I've implemented such an enum type. It might be a good idea that someone makes sure that all useful types are present though.
Comment 3 Guillaume Desmottes 2009-10-02 14:29:29 UTC
Created attachment 144597 [details] [review]
Code based on Jonathan's branch but, unfortunatelly, as the patches were badly recorded, I had to re-record it

 src/empathy-event-manager.c |   52 +++++++++++++++++++++++++-----------------
 src/empathy-event-manager.h |   20 ++++++++++++----
 2 files changed, 46 insertions(+), 26 deletions(-)
Comment 4 Guillaume Desmottes 2009-10-02 14:36:18 UTC
This bug has been fixed in master. Patch will probably be backported to 2.28.

commit 34010895cf8b0915b5f6bb162ba6165271b48c3c
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Fri Oct 2 15:16:27 2009 +0100

    add event type to EmpathyEvent (#589409)