GNOME Bugzilla – Bug 581917
Please show icons for devices
Last modified: 2010-12-09 12:47:01 UTC
PA sets PA_PROP_DEVICE_ICON for almost all sinks/sources now. It's an XDG icon name matching the 'form factor' and connector of the hw. I think it would make a lot of sense to make use of it in the UI to allow distuingishing sound cards more easily. i.e. show a camera icon for the web cam sound source, a TV icon for the TV card, and so on. When Rodney gets off his ass we'll hopefully also be able to provide different icons for headphones and external speakers and so on. Given that most device description strings are not exactly useful right now the icon could probably help users to identify their hardware more easily.
Created attachment 134293 [details] [review] gvc-add-device-icons.patch I guess you meant PA_PROP_DEVICE_ICON_NAME, PA_PROP_DEVICE_ICON seems to be empty for what I tried. Looks very very arse right now.
Hmm, when I apply that patch I don't see any icon. Hmm, the icon names PA sets need to be resolved with the fallback icon name logic enabled. I don't think the icon cell renderer does that by default. You might need to load those icons manually via gtk_icon_theme_load_icon(..., GTK_ICON_LOOKUP_GENERIC_FALLBACK). That's at least what I had to do in pavucontrol.
Created attachment 134317 [details] showing the icons That shows the PNG images.
Which all seem to be fallback ones... The cell renderer should probably be fixed to do fallback, as we don't have much control over the contents of the pixbuf itself.
BTW, I have now put up a request for more expressive icons for the form factors: http://live.gnome.org/GnomeArt/ArtRequests/GenericAudioIcons
Will need to: - wait for the icons to be made and useful - use a function to set the icon name, so we can do fallback ourselves - change the applet's tooltip to be <big>level</big>\nstuff (and not level\n<small>stuff</small>) - add an device icon to the tooltip
Created attachment 139686 [details] audio-headset icons by Hylke Bons and Andreas Nilsson (just some tweaks from me)
Created attachment 145346 [details] [review] Bug 581917 - Please show icons for devices Show device icons in the stream treeviews. Use GIcon to get automatic fallback.
let's try to get that in for 2.29.6, in 2 weeks from now, I'll catch you on irc.
Created attachment 151835 [details] Audio preferences with plugged USB speakers I've recently bought new USB speakers. The missing icon in attached screenshot (2.28) is due to this bug, isn't it? PS do you need any check/test/debug for this hardware?
Mass move to gnome-control-center.
(In reply to comment #10) > Created an attachment (id=151835) [details] > Audio preferences with plugged USB speakers > > I've recently bought new USB speakers. The missing icon in attached screenshot > (2.28) is due to this bug, isn't it? > > PS do you need any check/test/debug for this hardware? Probably not related, file a separate bug with the output of "pacmd list-cards"
And committed the icons as well, though they might need a little updating for the new style.
*** Bug 599109 has been marked as a duplicate of this bug. ***