After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580900 - Kill libgnomeui/gnome-dateedit
Kill libgnomeui/gnome-dateedit
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.26.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
evolution[cleanup]
Depends on:
Blocks: 580887
 
 
Reported: 2009-04-30 15:26 UTC by André Klapper
Modified: 2009-05-06 17:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Stop libgnome from dating (2.72 KB, patch)
2009-05-05 04:26 UTC, Adam Petaccia
committed Details | Review

Description André Klapper 2009-04-30 15:26:11 UTC
http://live.gnome.org/LibgnomeMustDie

./e-util/e-dialog-widgets.c:#include <libgnomeui/gnome-dateedit.h>
./calendar/gui/e-meeting-time-sel.c:#include <libgnomeui/gnome-dateedit.h>
Comment 1 Matthew Barnes 2009-05-01 02:44:16 UTC
Don't think we have a replacement for this yet in GTK+.
Comment 2 André Klapper 2009-05-03 20:17:54 UTC
<mclasen> first of all, I'd check how widely used the remaining parts are
<mclasen> no need to invest time in something thats barely used
<mclasen> I'm pretty sure evolution has its own date/time editing controls, e.g
<andre> according to my files here, "gnome_date_edit_" only exists in gnome-sharp and evolution.
<kmaraas> ok, so evolution is actually using it
<kmaraas> same result here - except the bindings and glade of course

...hence no need for GTK+ replacements.
Comment 3 Matthew Barnes 2009-05-03 21:12:21 UTC
I guess we'll be adopting GnomeDateEdit then?

More legacy shit to maintain...
Comment 4 Adam Petaccia 2009-05-05 04:26:44 UTC
Created attachment 133988 [details] [review]
Stop libgnome from dating

Correct me if I'm naive and young, but I couldn't find anything actually USING those functions. Was Evolution designed to use its own E_DATE_EDIT stuff long ago? Evo compiles fine with the attached patch (against 2.26.0).
Comment 5 André Klapper 2009-05-05 08:35:44 UTC
Same results here.

$:andre\> cd svn-gnome/evolution
$:andre\> grep -r e_dialog_dateedit_ .
./e-util/e-dialog-widgets.c: * e_dialog_dateedit_set:
./e-util/e-dialog-widgets.c:e_dialog_dateedit_set (GtkWidget *widget, time_t t)
./e-util/e-dialog-widgets.c: * e_dialog_dateedit_get:
./e-util/e-dialog-widgets.c:e_dialog_dateedit_get (GtkWidget *widget)
./e-util/e-dialog-widgets.h:void e_dialog_dateedit_set (GtkWidget *widget, time_t t);
./e-util/e-dialog-widgets.h:time_t e_dialog_dateedit_get (GtkWidget *widget);
./e-util/ChangeLog:	* e-dialog-widget.c (e_dialog_dateedit_get):
./e-util/ChangeLog.pre-1-4:	(e_dialog_dateedit_set): Likewise.
./e-util/ChangeLog.pre-1-4:	(e_dialog_dateedit_get): Likewise.
$:andre\> 
Comment 6 André Klapper 2009-05-05 08:45:00 UTC
I'd suspect that something like /widgets/misc/e-dateedit.c is used nowadays instead.
Comment 7 Matthew Barnes 2009-05-05 11:47:38 UTC
Oh awesome, I guess I should have checked for that to begin with.

Patch looks good; commit to master.  Thanks, Adam.
Comment 8 Matthew Barnes 2009-05-06 17:30:33 UTC
Committed Adam's patch to master in
http://git.gnome.org/cgit/evolution/commit/?id=dfb0db749801075ba67e24ac44de8fe9ac2ae2cc