After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 579045 - tab completion hard-codes ":", ignores completion_suffix
tab completion hard-codes ":", ignores completion_suffix
Status: RESOLVED FIXED
Product: xchat-gnome
Classification: Other
Component: general
HEAD
Other Linux
: Normal minor
: ---
Assigned To: xchat-gnome maintainers
xchat-gnome maintainers
Depends on:
Blocks: 602311
 
 
Reported: 2009-04-15 13:28 UTC by Wade Menard
Modified: 2010-03-24 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (949 bytes, patch)
2009-05-10 20:47 UTC, Ritesh Khadgaray ( irc:ritz) 		committed Details | Review

Description Wade Menard 2009-04-15 13:28:27 UTC 
xchat-gnome has hard coded ":" in tab_complete_nickname(), instead of using the completion_suffix setting in xchat.conf. Which happens to default to ","
Comment 1 vamp898 2009-04-16 13:45:18 UTC 
in which file plz? The source is huge^^
Comment 2 Christian Persch 2009-04-16 14:13:25 UTC 
tab_complete_nickname() is in ./src/fe-gnome/text-entry.c . The setting should be available via including "xchatc.h" from common/ and using the prefs.nick_suffix string.
Comment 3 vamp898 2009-04-16 14:56:41 UTC 
Why couldn´t this be solved by #define? Maybe a stupid question^^
Comment 4 Ritesh Khadgaray ( irc:ritz) 2009-05-10 20:47:44 UTC 
Created attachment 134364 [details] [review]
patch

#define does not cut it here. the attached patch replaces ":" with "%s" - prefs.nick_suffix .
Comment 5 Ritesh Khadgaray ( irc:ritz) 2009-10-23 18:31:02 UTC 
Review of attachment 134364 [details] [review]:

committed