After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578037 - Shouldn't use default Dbus timeout in calls to Policykit agent
Shouldn't use default Dbus timeout in calls to Policykit agent
Status: RESOLVED FIXED
Product: gnome-system-tools
Classification: Deprecated
Component: general
2.22.x
Other All
: Normal normal
: ---
Assigned To: Milan Bouchet-Valat
Carlos Garnacho
: 557572 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-04-05 15:30 UTC by Chris Coulson
Modified: 2009-08-19 16:29 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Patch applied in Ubuntu (1014 bytes, patch)
2009-04-05 15:32 UTC, Chris Coulson 		committed Details | Review

Description Chris Coulson 2009-04-05 15:30:53 UTC 
Please describe the problem:
gnome-system-tools currently uses the default DBus timeout when communicating with polkit-gnome-manager. On Ubuntu, this is only 10 seconds (I don't know what it is on other distributions), which can cause the call to timeout for some users before they even entered their password. 

Steps to reproduce:
1. Open users-admin
2. Click "Unlock"
3. Leave the dialog open for 10 seconds


Actual results:
The Dbus call times out, and an error appears. The user then has to close the existing polkit-gnome-manager dialog and try again.

Expected results:
The call should not timeout for a long time. No reply is expected until the user entered their password anyway.

Does this happen every time?
Yes

Other information:
Comment 1 Chris Coulson 2009-04-05 15:32:15 UTC 
Created attachment 132134 [details] [review]
Patch applied in Ubuntu

This is the patch currently applied in Ubuntu 9.04
Comment 2 Andy Owen 2009-07-18 10:16:13 UTC 
The patch looks good to me.

See:

http://dbus.freedesktop.org/doc/api/html/group__DBusConnection.html#ga951b2a6f6c4069fa392752000b24ebe 

For the specifics on the call (but INT_MAX is correct).
Comment 3 Milan Bouchet-Valat 2009-07-26 10:15:20 UTC 
Pushed as 8ac967dfcdd00313fa061550e4a92789e8ed3cb3. Thanks for the patch, it should be included in GNOME 2.27.6.
Comment 4 Milan Bouchet-Valat 2009-08-19 16:29:05 UTC 
*** Bug 557572 has been marked as a duplicate of this bug. ***