After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 573744 - libgnome-desktop has unlocalized RANDR message
libgnome-desktop has unlocalized RANDR message
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
unspecified
Other opensolaris
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks: randr-tracker
 
 
Reported: 2009-03-02 12:25 UTC by Takao Fujiwara
Modified: 2009-03-09 20:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for libgnome-desktop/gnome-rr.c (536 bytes, patch)
2009-03-02 12:26 UTC, Takao Fujiwara 		none Details | Review

Description Takao Fujiwara 2009-03-02 12:25:39 UTC 
When the X doesn't support RANDR, gnome-display-properties shows an error dialog.

The string "RANDR extension is not present" is generated by libgnome-desktop.so and it's not localized because bindtextdomain() is not called for the domain name.
Solaris default domain path is "/usr/lib/locale". libgnome-desktop .mo is installed in "/usr/share/locale".

I'm attaching the patch.
Comment 1 Takao Fujiwara 2009-03-02 12:26:35 UTC 
Created attachment 129847 [details] [review]
Patch for libgnome-desktop/gnome-rr.c

Attached the patch.
Comment 2 Vincent Untz 2009-03-03 17:20:41 UTC 
Good catch. I reused the code we have in gnome-desktop-item.c for this.