GNOME Bugzilla – Bug 573292
Remove deprecated GTK+ symbols
Last modified: 2010-05-28 10:42:58 UTC
http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/GTK%2B (Is gfloppy alive at all? If not, are there plans to remove it?) ========= GNOME-DICTIONARY ========= $:andre\> grep -r gtk_entry_set_editable . ./gnome-dictionary/src/gdict-applet.c: gtk_entry_set_editable (GTK_ENTRY (priv->entry), TRUE); ========= GFLOPPY ========= $:andre\> grep -r GTK_SIGNAL_FUNC . ./gfloppy/src/main.c: gtk_signal_connect (GTK_OBJECT (menu_item), "activate", GTK_SIGNAL_FUNC (devices_option_activated), list->data); ./gfloppy/src/progress.c: gtk_signal_connect (GTK_OBJECT (progress_dialog), "response", GTK_SIGNAL_FUNC (progress_response_callback), floppy); $:andre\> grep -r gdk_input_add . ./gfloppy/src/progress.c: floppy->handler_id = gdk_input_add (floppy->message[0], GDK_INPUT_READ, read_stdinput, floppy); $:andre\> grep -r gdk_input_remove . ./gfloppy/src/progress.c: gdk_input_remove (floppy->handler_id); $:andre\> grep -r gtk_menu_append . ./gfloppy/src/main.c: gtk_menu_append (GTK_MENU (menu), menu_item); $:andre\> grep -r gtk_option_menu_get_history . ./gfloppy/src/main.c: cannot_check = gtk_option_menu_get_history (type_om) == 1 && /* fat fs */ ./gfloppy/src/main.c: floppy.type = gtk_option_menu_get_history (GTK_OPTION_MENU (type_option)); /* user choice */ ./gfloppy/src/main.c: floppy.size = gtk_option_menu_get_history (GTK_OPTION_MENU (density_option)); ./gfloppy/src/main.c: switch (gtk_option_menu_get_history (GTK_OPTION_MENU (type_option))) { $:andre\> grep -r gtk_option_menu_get_menu . ./gfloppy/src/main.c: menu = gtk_option_menu_get_menu (GTK_OPTION_MENU (type_option)); $:andre\> grep -r gtk_option_menu_remove_menu . ./gfloppy/src/main.c: gtk_option_menu_remove_menu (GTK_OPTION_MENU (device_option)); $:andre\> grep -r gtk_option_menu_set_history . ./gfloppy/src/main.c: gtk_option_menu_set_history (GTK_OPTION_MENU (device_option), 0); ./gfloppy/src/main.c: gtk_option_menu_set_history (GTK_OPTION_MENU (type_option), GFLOPPY_FAT); ./gfloppy/src/main.c: gtk_option_menu_set_history (GTK_OPTION_MENU (type_option), GFLOPPY_E2FS); ./gfloppy/src/main.c: gtk_option_menu_set_history (GTK_OPTION_MENU (type_option), floppy.mke2fs_cmd ? 1 : 0); $:andre\> grep -r gtk_option_menu_set_menu . ./gfloppy/src/main.c: gtk_option_menu_set_menu (GTK_OPTION_MENU (device_option), menu); $:andre\> grep -r gtk_progress_bar_update . ./gfloppy/src/progress.c: gtk_progress_bar_update (GTK_PROGRESS_BAR (progressbar), $:andre\> grep -r gtk_signal_connect . ./gfloppy/src/main.c: gtk_signal_connect (GTK_OBJECT (menu_item), "activate", GTK_SIGNAL_FUNC (devices_option_activated), list->data); ./gfloppy/src/progress.c: gtk_signal_connect (GTK_OBJECT (progress_dialog), "response", GTK_SIGNAL_FUNC (progress_response_callback), floppy);
Created attachment 129584 [details] [review] use gtk_editable_set_editable trivial patch for src/gdict-applet.c
Please commit.
Commited as r8448: http://svn.gnome.org/viewvc/gnome-utils?view=revision&revision=8448 gfloppy stuff still remaining unless it is going to be removed.
do you still want to keep this bug open now that gfloppy is gone?
No, there's no point in keeping this opened.
Reopening as GTK_WIDGET_NO_WINDOW, GTK_WIDGET_STATE are used: $:andre\> grep -r GTK_WIDGET_NO_WINDOW . ./gnome-dictionary/src/gdict-aligned-window.c: if (GTK_WIDGET_NO_WINDOW (align_widget)) ./gnome-screenshot/screenshot-dialog.c: if (GTK_WIDGET_STATE (drawing_area) != GTK_STATE_NORMAL) ./gnome-screenshot/screenshot-dialog.c: GTK_WIDGET_STATE (drawing_area),
Created attachment 160578 [details] [review] Replace deprecated symbols. Port to GtkSpinner Built on top of my GSEAL patch for bug #612485. That one might have to be committed first. Also ports gsearchtool to use GtkSpinner.
Thanks for the patch. I split it into single commits and pushed it to master. In the future, please try to split such horizontal changes into separate commits, as that makes it easier to review them.
Cosimo: Big Thanks, as always!