Marking high because of the patch, but I presume with the new gsm this
isn't relevant for 2.0?

gnome-session hasn't been replaced for GNOME 2, it's the same basic deal.

My msm session manager has "splash screen themes" that can even
replace the special effects, but that's probably crackrock ;-)
I don't know when/if we'll use msm so adding this feature to gsm 
is likely still sensible.

Mass-marking after reading; 'luis doing GNOME2 work' can be filtered on.

New feature -> punting to 2.2.x

*** Bug 80457 has been marked as a duplicate of this bug. ***

There's another patch in #80457

Havoc: what is "splash screen themes"?

splash screen themes is loadable modules to change the special effects
seen as you log in.

Attaching a patch against gnome-session 2.0.7. I didn't add the UI to
the patch to change it, since it's not really a needed "feature" for
people who don't know how to go run gconf-editor and break things
anyway.

Created attachment 11210 [details] [review]
gnome-session 2.0 patch to add a themable splash image

Dobey: Thanks for an up to date patch :-) Some comments:

* There should be no hyphens in gconf keys
* The schemas should be translated. You'll want the file in the patch
to be gnome-session.schemas.in.in and add gnome-session.schemas.in to
POTFILES.in
* Don't use tab indentation for the schemas. It quickly becomes
unreadable.
* The owner should be 'gnome-session' although I don't think it makes
a difference

* I'd prefer ..

filename = gconf_client_get...
if (!filename)
        filename = g_strdup...

pb = gdk_pixbuf_new...

g_free (filename)

than

filename = gconf_client_get...

pb = gdk_pixbuf_get ...
g_free (filename)

if (!pb) {
      filename = g_strdup...
      pb = gdk_pixbuf_new_from ..
}

* The comment isn't neccessary
* Unref the GConfClient



Thanks again ..

Created attachment 11304 [details] [review]
Revised gnome-session themeable splash image patch

Thanks Mark,

The newly revised patch removes the hyphen, puts the schemas file in
POTFILES.in and moves it to .in.in, removes the comment, unrefs the
GConfClient object, and rearranges the code as you suggest. I left
the owner as "gnome" to be consistent with the other keys in the
schemas file. I'm not sure what you mean about the unreadability of
the schemas file. It was fine in both vi and emacs. Though, there
really should be a dtd that editors can validate it against and tab
it in a standardly readable fashion. I'll file a bug against GConf
for that. Also, is the hyphen thing an aesthetic concern, or one of
functionality that has been decided by multiple people to be the
standard way of doing it for GNOME?

GConf keys aren't supposed to contain a hyphen. Its a convention
apparently. I've forgotten whether is was arbitrary or if there is a
good reason for it.

I've committed the patch with the neccessary intltool/make magic to
actually merge the translations.

Thanks for the work.

*** Bug 97893 has been marked as a duplicate of this bug. ***

this bug should provide the patch for GUI of configuration.
but gnome-session HEAD has no such a code for setting gconf key GUIly.
bug 80457 has a try for it.

No. We need a cross-desktop method of theming the splash screen. This
should be similar to the other theming methods. I did the gconf key as
a quick hack to make this themeable as a billion people have been
asking for it. I'd like to write a "spec" for this, and update
gnome-session for 2.3/2.4 to follow this spec, and just make it easier
for people to
provide splash screens as part of a "metatheme" or other methods. I'll
reassign this bug to me and do something this week. Changing summary,
and updating keywords also.

Removing the PATCH keyword.

Rodney, any updates ?

Sorry. I haven't had time to look at this, and it seems that 2.4
feature freeze was yesterday. There also is not spec for the
"metatheme" stuff
yet, as far as I know. Maybe we can do something really nice for 2.6?

OK. So, I've been on vacation for the past 2 weeks and after my talk
at guadec, I started to think about some icon theme things. I think we
should just move to making the splash screens for applications be part
of the "icon" theme, as well as a lot of other things such as smilies,
status icons, application about box images, etc... Since the goal is
to have gtk 2.4 use icon themes for the stock icons and stuff, I think
we should retarget this for 2.6 and try to make the gtk+ icon theme
stuff as nice and extensible, and sane as possible. I have some
proposals for extensions and changes to the icon theme spec that I
would like to see end up making gnome/gtk better for 2.6/2.4
development cycles, as well as a quick reference implementation of an
icon theme object to support the changes better.

Moving this to "future" for now. Perhaps we should add a 2.6.x target?

Comment on attachment 11304 [details] [review]
Revised gnome-session themeable splash image patch

Lacking a 'committed' status, marking this obsolete.

*** Bug 111474 has been marked as a duplicate of this bug. ***

We don't have a splash screen anymore. It was off for a number of years before it was completely removed in GNOME 3.0.