GNOME Bugzilla – Bug 565453
Now playing baloon title
Last modified: 2010-02-17 20:33:57 UTC
The title of this dialog is "Now playing" which is bigger than the music that is playing and the author. I suggest to change the title to the name of the track, that is the most important info there, also, we don't need this title since is very clear that this dialog is about the music 'now playing' . Other information:
Created attachment 128891 [details] Now playing popup This is how the balloon looks like in the svn trunk version. I guess this bug has already been fixed and can be closed.
The balloon that pops up when the song changes is different.
Created attachment 131408 [details] [review] Improving now playing notification pop-up This patch replaces the "Now Playing" title with the name of the song. It also shows the album name as some space has been freed up. I'm going to attach before/after screen-shots.
Created attachment 131409 [details] before
Created attachment 131410 [details] after
I think adding the 'by' and 'from' would be helpful - I get confused with bands I'm not familiar with what is the band name and what is the album name.
Created attachment 131466 [details] [review] Added "by X from Y" (In reply to comment #6) > I think adding the 'by' and 'from' would be helpful - I get confused with bands > I'm not familiar with what is the band name and what is the album name. > Good idea! This patch borrows the code from TrackInfoDisplay to create the by/from markup. I will attach the screen-shot.
Created attachment 131467 [details] after v2
*** Bug 586105 has been marked as a duplicate of this bug. ***
so if this has a working patch from 3 months ago then why is this problem still existing in latest unstable release versions of 1.5 series? please merge it.
Created attachment 138104 [details] [review] Updated to git master
Created attachment 145278 [details] [review] Updated to git master
Bulk changing the assignee to banshee-maint@gnome.bugs to make it easier for people to get updated on all banshee bugs by following that address. It's usually quite apparent who is working on a given bug by the comments and/or patches attached.
Thanks for review, Gabriel! This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
This patch both breaks the the GtkNotificationAreaBox implementation since it assumes that notif_area.Widget really returns something useful, whereas GtkNotificationAreaBox.Widget == null.