After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 564655 - Port gnome-sudoku to use Gtk instead of deprecated gnome-print
Port gnome-sudoku to use Gtk instead of deprecated gnome-print
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnome-sudoku
trunk
Other Linux
: High normal
: gnome-2-28
Assigned To: Thomas Andersen
GNOME Games maintainers
Depends on:
Blocks: 565726
 
 
Reported: 2008-12-15 20:08 UTC by André Klapper
Modified: 2009-06-17 00:34 UTC
See Also:
GNOME target: 2.28.x
GNOME version: ---


Attachments
Unfinished patch (23.10 KB, patch)
2009-03-18 11:36 UTC, Thomas Andersen
needs-work Details | Review

Description André Klapper 2008-12-15 20:08:04 UTC
See http://live.gnome.org/GtkPrintPort

gnome-sudoku is one of the very last modules using deprecated gnomeprint in gnome-sudoku/src/lib/printing.py.
Comment 1 Thomas Andersen 2008-12-16 08:49:29 UTC
Unless someone beats me to it I will do the port in mid-January. I have a few days off there.
Comment 2 André Klapper 2009-01-20 22:30:32 UTC
it's mid-january... *drumroll* :)
Comment 3 Thomas Andersen 2009-01-22 23:58:17 UTC
I have been looking at this a bit but have not yet completed the port. It looks like it could be a bit more complicated than I had first guessed. I have two exams on monday and wednesday that I need to prepare for. After that I should have some time again.

If anyone feels like doing it before me they are more than welcome :)
Comment 4 Thomas Andersen 2009-02-03 00:23:12 UTC
this is 2.27 material now I'm afraid :(
Comment 5 André Klapper 2009-02-03 00:40:27 UTC
...feel free to post the patch here and mark it as needs-work.
Comment 6 Thomas Andersen 2009-02-04 13:18:26 UTC
If it is not considered hit by the various freezes I might find time for it in the next days or perhaps during fosdem. If not I will prioritize bugs instead and do it early for 2.27.
Comment 7 Sebastien Bacher 2009-03-18 11:21:30 UTC
that's still an issue in 2.26 and the only GNOME component still using libgnomeprint
Comment 8 Thomas Andersen 2009-03-18 11:36:41 UTC
Created attachment 130879 [details] [review]
Unfinished patch

I have a patch that mostly fixes this. It is not finished and has regressions like not printing the label of the sudoku and also the drawing needs a bit adjustment. But except for that it works, it is just not quite ready for commit. I will fix the small regressions, clean it up, and commit it soon.
Comment 9 Thomas Andersen 2009-03-20 01:19:07 UTC
Updated patch with fixes commited on trunk as r8870:
http://svn.gnome.org/viewvc/gnome-games?view=revision&revision=8870