GNOME Bugzilla – Bug 562185
SHAMROCK_FIND_PROGRAM_OR_BAIL doesn't bail
Last modified: 2009-01-21 20:03:31 UTC
Please describe the problem: Hi build/m4/shamrock/programs.m4 in banshee has 7 AC_DEFUN([SHAMROCK_FIND_PROGRAM_OR_BAIL], 8 [ 9 SHAMROCK_FIND_PROGRAM($1, $2, no) 10 if test "x$1" = "xno"; then 11 AC_MSG_ERROR([You need to install '$2']) 12 fi 13 ]) so it will substitute the first argument in the test, e.g. if test "xMCS" = "xno"; then which is obviously always false. This means that ./configure doesn't bail if gmcs is not found, and eventually leads to make trying to compile banshee with "no" as the compiler. Thanks, James Steps to reproduce: Run ./configure without gmcs on your path Actual results: ./configure reports "no <flags>" as the compiler. make tries to use "no" as the compiler. You are not told that you need to install gmcs Expected results: ./configure to bail out with a message about needing gmcs Does this happen every time? Yes Other information:
Created attachment 123387 [details] [review] Do a double substitution on the parameter to SHAMROCK_FIND_PROGRAM_OR_BAIL Good catch, thanks ! Here's a simple patch that fixes this.
Looks good, commit after 1.4.2.
*** Bug 567717 has been marked as a duplicate of this bug. ***
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.