After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 562185 - SHAMROCK_FIND_PROGRAM_OR_BAIL doesn't bail
SHAMROCK_FIND_PROGRAM_OR_BAIL doesn't bail
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other All
: Normal minor
: 1.6
Assigned To: Banshee Maintainers
Banshee Maintainers
: 567717 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-11-24 22:02 UTC by James Westby
Modified: 2009-01-21 20:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do a double substitution on the parameter to SHAMROCK_FIND_PROGRAM_OR_BAIL (416 bytes, patch)
2008-11-25 20:07 UTC, Bertrand Lorentz
committed Details | Review

Description James Westby 2008-11-24 22:02:38 UTC
Please describe the problem:
Hi

build/m4/shamrock/programs.m4 in banshee has

7 	AC_DEFUN([SHAMROCK_FIND_PROGRAM_OR_BAIL],
8 	[
9 	SHAMROCK_FIND_PROGRAM($1, $2, no)
10 	if test "x$1" = "xno"; then
11 	AC_MSG_ERROR([You need to install '$2'])
12 	fi
13 	]) 

so it will substitute the first argument in the test, e.g.

      if test "xMCS" = "xno"; then

which is obviously always false.

This means that ./configure doesn't bail if gmcs is not found,
and eventually leads to make trying to compile banshee with "no"
as the compiler.

Thanks,

James


Steps to reproduce:
Run ./configure without gmcs on your path

Actual results:
./configure reports "no <flags>" as the compiler.
make tries to use "no" as the compiler.
You are not told that you need to install gmcs

Expected results:
./configure to bail out with a message about needing gmcs

Does this happen every time?
Yes

Other information:
Comment 1 Bertrand Lorentz 2008-11-25 20:07:11 UTC
Created attachment 123387 [details] [review]
Do a double substitution on the parameter to SHAMROCK_FIND_PROGRAM_OR_BAIL

Good catch, thanks !

Here's a simple patch that fixes this.
Comment 2 Gabriel Burt 2009-01-13 17:56:57 UTC
Looks good, commit after 1.4.2.
Comment 3 Gabriel Burt 2009-01-14 15:30:25 UTC
*** Bug 567717 has been marked as a duplicate of this bug. ***
Comment 4 Bertrand Lorentz 2009-01-21 20:03:31 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.