After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560432 - Cleaning up GTK Includes in nautilus
Cleaning up GTK Includes in nautilus
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] Builds
0.x.x [obsolete]
Other All
: Normal trivial
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 563413
 
 
Reported: 2008-11-12 02:16 UTC by Maxim Ermilov
Modified: 2008-12-06 10:26 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Patch for this bug (7.22 KB, patch)
2008-11-12 02:59 UTC, Maxim Ermilov 		committed Details | Review

Description Maxim Ermilov 2008-11-12 02:16:58 UTC 
Please describe the problem:
I'm working on implementing http://live.gnome.org/GnomeGoals/CleanupGTKIncludes

If it's not a good idea, or not currently on the agenda, please let me know.
Otherwise I'll be working on this for now.


Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 A. Walton 2008-11-12 02:59:07 UTC 
Thank you for reporting, but I think we already took care of these in bug 530315. If we didn't, please reopen and we'll get a patch in.
Comment 2 Maxim Ermilov 2008-11-12 02:59:38 UTC 
Created attachment 122466 [details] [review]
Patch for this bug
Comment 3 A. Walton 2008-11-12 03:03:49 UTC 
Spoke too soon eh? I think this would be fine to commit, with a changelog entry.
Comment 4 Cosimo Cecchi 2008-12-06 10:26:43 UTC 
Committed to trunk.

2008-12-06  Cosimo Cecchi  <cosimoc@gnome.org>

	* cut-n-paste-code/libegg/eggtreemultidnd.c:
	* cut-n-paste-code/libegg/eggtreemultidnd.h:
	* libnautilus-extension/nautilus-menu.c:
	* libnautilus-private/nautilus-directory-notify.h:
	* libnautilus-private/nautilus-file-operations.c:
	* libnautilus-private/nautilus-file.c:
	* libnautilus-private/nautilus-icon-info.h:
	* libnautilus-private/nautilus-idle-queue.h:
	* libnautilus-private/nautilus-monitor.h:
	* libnautilus-private/nautilus-search-engine-simple.c:
	* src/file-manager/fm-list-model.c:
	* src/file-manager/fm-list-model.h:
	* src/file-manager/fm-list-view.c:
	* src/nautilus-emblem-sidebar.h:
	* src/nautilus-notebook.c:
	* src/nautilus-notebook.h:
	Use single GLib/GTK+ includes. Patch by Maxim Ermilov (#560432).