After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 558775 - save "show controls" checkbox
save "show controls" checkbox
Status: RESOLVED DUPLICATE of bug 328590
Product: totem
Classification: Core
Component: general
2.24.x
Other All
: Normal minor
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-11-01 10:16 UTC by david yang
Modified: 2008-12-02 10:10 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24



Description david yang 2008-11-01 10:16:43 UTC
I found the source code area:

line 3531 of totem.c in totem-2.24.3
totem->controls_visibility = TOTEM_CONTROLS_UNDEFINED;

Please make it save setting to gconf, it is very frustrating to press H every time I use totem. 

Perhaps something like:
totem->controls_visibility = (int) gconf_client_get_int (totem->gc,GCONF_PREFIX"/controls_visibility", NULL))

And save the setting's current value into gconf at exit.

Thank You!

Other information:
When trying to recompile it to 
totem->controls_visibility = TOTEM_CONTROLS_HIDDEN; (my personal preference hack)
under ubuntu, the configuration file is messed up. Ubuntu's fault for renaming gstreamer.
Comment 1 Bastien Nocera 2008-12-01 12:12:33 UTC
Saving the state is out of the question, as you wouldn't want people to end up being confused when they toggle the controls visibility by mistake, and restart Totem hoping to get back to the original view.

But "totem --toggle-controls" on the first instance should work better than it currently does (which is _very badly_).

*** This bug has been marked as a duplicate of 328590 ***
Comment 2 david yang 2008-12-02 04:17:30 UTC
Thank you for your clarification.

However, is it possible to make it read the setting from gconf, with a schema to default to "controls_showing", but do not save the value when the app exits. 

Therefore it is editable from gconf-editor, but doesn't save the settings - which is how lots of hidden settings in gnome work (such as the animations in gnome panel which cannot be turned off by a setting manager, but can me manually overridden). I have already provided the source code required to read from gconf.

Cheers
Comment 3 Bastien Nocera 2008-12-02 10:10:53 UTC
I'm not really interested in adding it to GConf, but you could easily do that. The same problem as bug 328590 would currently happen anyway...