After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557344 - Add support for Audioscrobbler Love/Ban actions on non-radio source.
Add support for Audioscrobbler Love/Ban actions on non-radio source.
Status: RESOLVED DUPLICATE of bug 527373
Product: banshee
Classification: Other
Component: Last.fm
git master
Other Linux
: Normal enhancement
: 1.x
Assigned To: Gabriel Burt
Depends on:
Blocks:
 
 
Reported: 2008-10-22 02:05 UTC by Warren Seine
Modified: 2008-12-15 02:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add support for Audioscrobbler Love/Ban actions on non-radio source. (34.29 KB, patch)
2008-10-22 02:06 UTC, Warren Seine
none Details | Review

Description Warren Seine 2008-10-22 02:05:26 UTC
Last.fm's Love/Ban actions are currently available when playing a radio stream from Last.fm.

This patch adds support for Love/Ban actions to Banshee when playing any song with artist and track tags. When a song is loaded (playing or paused), if an user is connected to Last.fm, you should now see smileys on the top-right part of the client. Otherwise, they disappear.

Here is the ChangeLog:

2008-10-21  Warren Seine  <warren.seine@gmail.com>

	Add support for Audioscrobbler Love/Ban actions on non-radio
	source.

	* src/Extensions/Banshee.Lastfm/Banshee.Lastfm.Audioscrobbler/
	AudioscrobblerActions.cs: New. Separate GUI from service.

	* src/Extensions/Banshee.Lastfm/Banshee.Lastfm.Audioscrobbler/AudioscrobblerService.cs:
	* src/Extensions/Banshee.Lastfm/Banshee.Lastfm.Radio/LastfmActions.cs:
	Move Love/Ban actions to Banshee.Lastfm.Audioscrobbler instead
	of Banshee.Lastfm.Radio. Radio and scrobbling work separately.

	* src/Extensions/Banshee.Lastfm/Banshee.Lastfm.csproj:
	* src/Extensions/Banshee.Lastfm/Makefile.am: Updated with new file.

	* src/Extensions/Banshee.Lastfm/Resources/GlobalUI.xml:
	* src/Extensions/Banshee.Lastfm/Resources/LastfmTrackActions.xml:
	Update GUI to show the Love/Ban smiley/buttons even if the
	current source is local (appears if connected to Last.fm and
	having a song loaded).

	Still a small problem in the NotificationArea: the Love/Ban entries
	do not appear in their placeholder. Looks like a bug cause by
	the Audioscrobbler plugin being loaded before the NotificationArea
	plugin.

	* src/Libraries/Lastfm/Lastfm/AudioscrobblerConnection.cs:
	Change enum State to AudioscrobblerState (for coherence with
	RadioConnection.cs).
	Add handler on Audioscrobbler state change.
Comment 1 Warren Seine 2008-10-22 02:06:51 UTC
Created attachment 121080 [details] [review]
Add support for Audioscrobbler Love/Ban actions on non-radio source.
Comment 2 Warren Seine 2008-10-25 23:09:15 UTC
Any review?
Comment 3 Bertrand Lorentz 2008-12-14 20:10:50 UTC
Bug #527373 is about the same enhancement, and already has some discussion. Would you mind attaching your patch there and mark this as a duplicate ?

Sorry for not noticing this earlier.
Comment 4 Warren Seine 2008-12-15 02:49:34 UTC

*** This bug has been marked as a duplicate of 527373 ***