After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 546929 - Use libcanberra for sound events
Use libcanberra for sound events
Status: RESOLVED DUPLICATE of bug 603152
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: 2.26
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-08-08 12:37 UTC by Patryk Zawadzki
Modified: 2009-11-30 22:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use libcanberra instead of gst-audio-play (4.41 KB, patch)
2008-08-08 12:39 UTC, Patryk Zawadzki
none Details | Review
Better patch (6.11 KB, patch)
2008-08-08 19:23 UTC, Patryk Zawadzki
none Details | Review
updated patch (13.99 KB, patch)
2009-08-04 00:03 UTC, daniel g. siegel
none Details | Review

Description Patryk Zawadzki 2008-08-08 12:37:20 UTC
Since we now have a proper sound naming specification and a sound theme specification, we should use the newly accepted libcanberra for sound events.

As per spec (http://0pointer.de/public/sound-naming-spec.html) there is now a "camera-shutter" event that we should use for taking pictures.

Cheese could either push the shutter sample to the Freedesktop sound theme (as it is lacking one at the moment) or try to provide its own (this might result in a file name collision as I expect the Freedesktop theme to provide sounds for all named events at the moment of shipping 2.24).
Comment 1 Patryk Zawadzki 2008-08-08 12:39:09 UTC
Created attachment 116136 [details] [review]
Use libcanberra instead of gst-audio-play

This patch makes the gst-audio-play.* files obsolete so they can be removed. waf script was patched but not checked.
Comment 2 Patryk Zawadzki 2008-08-08 12:57:49 UTC
Notice there is also "count-down" event we can trigger in the countdown widget :)
Comment 3 Patryk Zawadzki 2008-08-08 13:18:28 UTC
Adding Lennart to CC as I believe he is the maintainer of the Freedesktop sound theme.

Lennart:

Cheese has a shutter sound that could be moved to the fd.o sound theme (so we can use libcanberra-gtk).
Comment 4 Lennart Poettering 2008-08-08 18:04:14 UTC
It would make a lot of sense to move it into the freedesktop theme. However, according to Daniel the license of that file is not clear, which ties my hands. 

It might be possible to find a good free sound here though:
http://wiki.laptop.org/go/Sound_samples

Anyone up to it?
Comment 5 Patryk Zawadzki 2008-08-08 19:23:52 UTC
Created attachment 116181 [details] [review]
Better patch

Add countdown sounds and proper i18n/a11y
Comment 6 daniel g. siegel 2008-08-10 15:11:29 UTC
(In reply to comment #4)
> It would make a lot of sense to move it into the freedesktop theme. However,
> according to Daniel the license of that file is not clear, which ties my hands. 
> 

yes, we cant use my sound as i just recorded the clicking of my digital camera...
Comment 7 Patryk Zawadzki 2008-08-10 15:49:53 UTC
Here's a nice sound that could be easily cut into a perfect sample:

http://www.freesound.org/samplesViewSingle.php?id=16071

I'm sure analog camera noises (Nikon F4 is from the '80s) cannot be copyrighted by Nikon. Not sure if the CC-Sample+ license is good enough though.

Could someone contact the author and ask him to donate a sub-sample of the file under a compatible license (which one? LGPL? GPL? CC-BY-SA?) in exchange for making the world a better place and source attribution?
Comment 8 Lennart Poettering 2008-08-14 19:55:24 UTC
CC-Sample+ is not enough unfortunately. CC-BY 3.0 and CC-BY-SA 3.0 are the only CC licenses considered "Free" by DFSG and FSF, as far as I understood.

I am happy to merge any good sound into s-t-f as long as the license is good.
Comment 9 daniel g. siegel 2009-06-22 11:04:26 UTC
does libcanberra feature a camera click now?
Comment 10 daniel g. siegel 2009-07-26 23:13:40 UTC
lennart, are you back from gc? ;)

couldnt find a release of the new sound theme yet, will it be ready for 2.28?
Comment 11 Lennart Poettering 2009-07-28 14:47:47 UTC
I prepped a patch for Jon now to include the camera shutter sound in the tarball (it was only missing in the makefile, it was in the repo since about always). We'll see when he preps a new tarball.
Comment 12 Lennart Poettering 2009-07-28 20:29:09 UTC
New tarball of sound-theme-freedesktop with camera-shutter.ogg is now rolled and even already in Rawhide.
Comment 13 daniel g. siegel 2009-08-04 00:03:08 UTC
Created attachment 139833 [details] [review]
updated patch

updated patch
Comment 14 daniel g. siegel 2009-11-30 22:58:57 UTC

*** This bug has been marked as a duplicate of bug 603152 ***