Bug 544357 – sudoku sometimes does not detect completed puzzle

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 544357 - sudoku sometimes does not detect completed puzzle


Summary:	sudoku sometimes does not detect completed puzzle


Status:	RESOLVED DUPLICATE of bug 516491

Product:	gnome-games-superseded
Classification:	Deprecated
Component:	gnome-sudoku
Version:	2.22.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	GNOME Games maintainers
QA Contact:	GNOME Games maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2008-07-23 14:35 UTC by Josselin Mouette
Modified:	2009-10-28 17:19 UTC

See Also:
GNOME target:	---
GNOME version:	2.21/2.22

Description Josselin Mouette 2008-07-23 14:35:36 UTC

[ Forwarded from http://bugs.debian.org/489822 by Eric Cooper ]

Sometimes sudoku does not realize I have completed a puzzle.  It seems
to occur when I use a tracker for a while, then revert to using no
tracker.  I fill in the final square, but it does not notice that the
puzzle is complete.  If I quit the program and then resume the saved
game, as soon as I re-fill a square it detects that it's complete.

Comment 1 Allan Day 2008-07-24 01:03:34 UTC

Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.


*** This bug has been marked as a duplicate of 423478 ***

Comment 2 Josselin Mouette 2008-07-24 08:10:40 UTC

I don’t think it is the same bug. This one was reported with 2.22.2.1, which has the fix for bug#423478 included.

Comment 3 Allan Day 2008-07-24 10:39:48 UTC

Josselin: I hadn't noticed that 423478 had been fixed. Thanks for pointing it out.

Recent comments posted on bug 423478 suggest that it might not have fully fixed, so this could be a duplicate.

Comment 4 DrC 2009-03-01 19:36:24 UTC

423478 has not been fixed.

Workaround: if you delete any failed tracks by hand games complete OK.  If you use the 'clear track' feature you (get/risk?) a game that does not realise it has been completed.

The problem has been recognised as an error in the game record - can't remember the details.  The corruption seems to come when a track is cleared by the button.

Comment 5 DrC 2009-03-01 19:38:49 UTC

PS I do not understand why this is still unconfirmed - surely dupes confirm bugs?

Comment 6 Josselin Mouette 2009-03-23 15:13:29 UTC

http://bugs.debian.org/514781 may contain some valuable input to help fixing this bug.

When sudoku is not detecting that the puzzle is completed, the user tried saving the game and restarting it later. He got this crash:

  Traceback (most recent call last):

+ Trace 213769

File "/usr/games/gnome-sudoku", line 66 in <module>
```
start_game()
```
File "/var/lib/python-support/python2.5/gnome_sudoku/gnome_sudoku.py", line 21 in start_game
```
main.start_game()
```
File "/var/lib/python-support/python2.5/gnome_sudoku/main.py", line 1055 in start_game
```
u = UI()
```
File "/var/lib/python-support/python2.5/gnome_sudoku/main.py", line 199 in __init__
```
if self.select_game():
```
File "/var/lib/python-support/python2.5/gnome_sudoku/main.py", line 64 in _
```
ret = fun(ui,*args,**kwargs)
```
File "/var/lib/python-support/python2.5/gnome_sudoku/main.py", line 213 in select_game
```
choice = game_selector.NewOrSavedGameSelector().run_swallowed_dialog(self.swallower)
```
File "/var/lib/python-support/python2.5/gnome_sudoku/game_selector.py", line 191 in run_swallowed_dialog
```
self.setup_dialog()
```
File "/var/lib/python-support/python2.5/gnome_sudoku/game_selector.py", line 76 in setup_dialog
```
self.make_saved_game_model()
```
File "/var/lib/python-support/python2.5/gnome_sudoku/game_selector.py", line 151 in make_saved_game_model
```
sudoku.sudoku_grid_from_string(g['game'].split('\n')[1].replace(' ','')).grid,
```
File "/var/lib/python-support/python2.5/gnome_sudoku/sudoku.py", line 232 in sudoku_grid_from_string
```
assert(len(s)<=GROUP_SIZE**2)   AssertionError
```


Apparently, the saved session contains None instead of 0, somewhere in the array. This could explain this bug if this None appeared somewhere in the program state.

Comment 7 Akhil Laddha 2009-10-14 03:59:25 UTC

could be a dupe of bug 516491 as per comment#6

Comment 8 Fabio Durán Verdugo 2009-10-28 17:19:31 UTC

yes!

*** This bug has been marked as a duplicate of bug 516491 ***