After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 542324 - When launch Firefox 3.0 and pressing CTRL+Orca+space key, In Orca application preferences /keybindings page some structural navigation description not marked for translation.
When launch Firefox 3.0 and pressing CTRL+Orca+space key, In Orca application...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: i18n
2.23.x
Other All
: Normal normal
: 2.24.0
Assigned To: Willie Walker
Depends on:
Blocks: 404403
 
 
Reported: 2008-07-10 08:20 UTC by Hammer Attila
Modified: 2009-03-10 00:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
This is my hungarian translation file. (272.18 KB, text/plain)
2008-07-11 13:38 UTC, Hammer Attila
  Details
Simple misplaced parentheses (1.12 KB, patch)
2008-07-11 19:48 UTC, Willie Walker
committed Details | Review

Description Hammer Attila 2008-07-10 08:20:47 UTC
Please describe the problem:
I translated the new structural navigation keybinding function names with hungarian language, all function name translated correctly, except this names:
Goes to next heading at level %d
Goes to previous heading at level %d.
Where %d is a heading level number (1-6) displayed with application preference GUI/keybindings page, with Firefox section.
It is interesting, because the hu.po file contains this two strins and translators comments:
#. Translators: this is for navigating in a document by heading.
#. (e.g. <h1> is a heading at level 1).
#.
#: ../src/orca/structural_navigation.py:2506
msgid "Goes to previous heading at level %d."
msgstr "Ugrás az előző %d szintű címsorra."

#. Translators: this is for navigating in a document by heading.
#. (e.g. <h1> is a heading at level 1).
#.
#: ../src/orca/structural_navigation.py:2506
msgid "Goes to previous heading at level %d."
msgstr "Ugrás az előző %d szintű címsorra."

I don't understand why not translated this strings?

Thanks,

Attila


Steps to reproduce:
1. Please launch Mozilla Firefox 3.0.
 
2. Please press Ctrl+Insert+Space (or Ctrl+Caps Lock+Space with laptop keyboard)

3. Please navigate the keybindings page, and Firefox section see this untranslate problem.



Actual results:
Every tryed.

Expected results:


Does this happen every time?
Yes

Other information:
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-07-11 08:06:42 UTC
Will: If Attila said it wasn't marked for translation at all, I'd know where to start looking.  But if the strings are showing up in his hu.po file....

And, yes, I'll add i18n to my repertoire over time, but a hint now would be awesome. :-)

Thanks!
Comment 2 Hammer Attila 2008-07-11 08:39:29 UTC
Joan Marie, your Firefox Orca application preferences displays correct translated strings? 
I absolute make sintax correct translation, not marked fuzzy this string. :-):-)
I don't understand.

Attila
Comment 3 Willie Walker 2008-07-11 13:25:25 UTC
I'm a bit build/install impaired at the moment (reinstalling my OS), but I'm seeing something odd in the comments:

> It is interesting, because the hu.po file contains this two strins and
> translators comments:
> #. Translators: this is for navigating in a document by heading.
> #. (e.g. <h1> is a heading at level 1).
> #.
> #: ../src/orca/structural_navigation.py:2506
> msgid "Goes to previous heading at level %d."
> msgstr "Ugrás az előző %d szintű címsorra."
> 
> #. Translators: this is for navigating in a document by heading.
> #. (e.g. <h1> is a heading at level 1).
> #.
> #: ../src/orca/structural_navigation.py:2506
> msgid "Goes to previous heading at level %d."
> msgstr "Ugrás az előző %d szintű címsorra."

These two strings are identical.  

Can you attach your hu.po file so we can test?
Comment 4 Hammer Attila 2008-07-11 13:32:09 UTC
Ok Will, just a moment please. Please not surprise, lot of new keynames string you see, because I put new patch with yesterday with another bug, but not committed with svn yet.

Attila
Comment 5 Hammer Attila 2008-07-11 13:38:46 UTC
Created attachment 114387 [details]
This is my hungarian translation file.
Comment 6 Willie Walker 2008-07-11 19:48:21 UTC
Created attachment 114409 [details] [review]
Simple misplaced parentheses

Looks like a simple misplaced parenthesis problem in two spots.  Instead of this:

_("Blah blah %d." % i)

We want this:

_("Blah blah %d.") % i

The reason for this is that the goal is to get the translated string that contains the "%d" in it and then do the integer format handling on the translated string.
Comment 7 Willie Walker 2008-07-11 19:49:29 UTC
Attila - can you try the attached patch please?
Comment 8 Hammer Attila 2008-07-12 06:20:13 UTC
Will, niceful the attached patch. This bug is fixed. Please commit with svn trunk your patch.

Attila
Comment 9 Willie Walker 2008-07-14 19:05:14 UTC
Thanks!  Committed and closing as FIXED for 2.23.5 since you tested it.  Thanks!
Comment 10 Hammer Attila 2008-07-14 19:58:07 UTC
Thanks Will.

Attila