GNOME Bugzilla – Bug 529129
Unhelpful messages when opening files
Last modified: 2008-08-30 06:57:21 UTC
Please describe the problem: When there is a pb opening a file (non existent file, no read access, ...) you get a generic message "Unable to open document / Unknown MIME Type" which has nothing to do with the error. When you open a file which format is unsupported the error message is not informative enough. For instance when you try to open a MSWord document you get "Unhandled MIME type: "application/x-ole-storage"" This kind of message doesn't mean a lot to my granny. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 109602 [details] [review] Patch against libdocument/ev-document-factory.c Changes in this patch: - More user friendly message when opening an unsupported file type - Print GIO error when a problem occurs during opening of a file
Applied, thanks a lot!
Comment on attachment 109602 [details] [review] Patch against libdocument/ev-document-factory.c >--- libdocument/ev-document-factory.c 2008-04-20 23:21:45.000000000 +0200 >+++ libdocument/ev-document-factory.c.new 2008-04-20 23:21:24.000000000 +0200 >@@ -191,9 +187,9 @@ > g_set_error (error, > EV_DOCUMENT_ERROR, > 0, >- _("Unhandled MIME type: “%s”"), mime_type); >+ _("%s (%s) is not a supported file type and cannot be opened"), g_content_type_get_description(mime_type),mime_type); Note that g_content_type_get_description returns a new allocated string, so you are leaking that string here. I've just fixed it in svn. > g_free (mime_type); >- >+ > return NULL; > } > What dou you think about using only the mime description? I think mime-type might be a bit cryptic for the user.
*** Bug 541695 has been marked as a duplicate of this bug. ***
*** Bug 549894 has been marked as a duplicate of this bug. ***