GNOME Bugzilla – Bug 523459
oocalc/bug_356334.py regression tests #1 through #4 produce the wrong results.
Last modified: 2009-03-10 00:05:21 UTC
Test 1 of 4 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_356334.py:Press the down arrow to move to cell A2 EXPECTED: "BRAILLE LINE: 'soffice Application fruit - OpenOffice.org Calc Frame fruit - OpenOffice.org Calc RootPane ScrollPane Document view3 Sheet Sheet1 Table Good in Pies Cell A2 '", " VISIBLE: 'Good in Pies Cell A2 ', cursor=1", "SPEECH OUTPUT: 'Good in Pies A2'", ACTUAL: "BRAILLE LINE: 'soffice Application Frame fruit - OpenOffice.org Calc RootPane ScrollPane Document view3 Sheet Sheet1 Table Good in Pies 0 Cell'", " VISIBLE: 'Good in Pies 0 Cell', cursor=1", "SPEECH OUTPUT: ''", "SPEECH OUTPUT: 'Good in Pies'", "SPEECH OUTPUT: ' not selected'", Test 2 of 4 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_356334.py:Type Insert-f to get text attributes on the current cell (A2) EXPECTED: "BUG: not speaking anything", ACTUAL: "", Test 3 of 4 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_356334.py:Press the right arrow to move to cell B2 EXPECTED: "BRAILLE LINE: 'soffice Application fruit - OpenOffice.org Calc Frame fruit - OpenOffice.org Calc RootPane ScrollPane Document view3 Sheet Sheet1 Table Yes Cell B2 '", " VISIBLE: 'Yes Cell B2 ', cursor=1", "SPEECH OUTPUT: 'Yes B2'", ACTUAL: "BRAILLE LINE: 'soffice Application Frame fruit - OpenOffice.org Calc RootPane ScrollPane Document view3 Sheet Sheet1 Table Yes 0 Cell'", " VISIBLE: 'Yes 0 Cell', cursor=1", "SPEECH OUTPUT: ''", "SPEECH OUTPUT: 'Yes'", "SPEECH OUTPUT: ' not selected'", Test 4 of 4 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_356334.py:Type Insert-f to get text attributes on the current cell (B2) EXPECTED: "BUG: not speaking anything", ACTUAL: "",
Created attachment 107681 [details] [review] Part of the patch for bug #518914 that solves the "not selected" differences. Yes, this patch does make the "not selected" differences go away. Unless there are any objections, I'd like to check this in ASAP (both for SVN trunk and the gnome-2-22 branch). Joanie, that would mean that the patch for bug #518914 should be adjusted not to include that chunk. Also, (as you point out), there are other differences. Here's what I now get for these four tests: Test 1 of 4 FAILED: ../keystrokes/oocalc/bug_356334.py:Press the down arrow to move to cell A2 EXPECTED: "BRAILLE LINE: 'soffice Application fruit - OpenOffice.org Calc Frame fruit - OpenOffice.org Calc RootPane ScrollPane Document view3 Sheet Sheet1 Table Good in Pies Cell A2 '", " VISIBLE: 'Good in Pies Cell A2 ', cursor=1", "SPEECH OUTPUT: 'Good in Pies A2'", ACTUAL: "BRAILLE LINE: 'soffice Application Frame fruit - OpenOffice.org Calc RootPane ScrollPane Document view3 Sheet Sheet1 Table Good in Pies Cell A2 '", " VISIBLE: 'Good in Pies Cell A2 ', cursor=1", "SPEECH OUTPUT: 'Good in Pies A2'", [FAILURE WAS UNEXPECTED] Test 2 of 4 FAILED: ../keystrokes/oocalc/bug_356334.py:Type Insert-f to get text attributes on the current cell (A2) EXPECTED: "BUG: not speaking anything", ACTUAL: "", [FAILURE WAS UNEXPECTED] Test 3 of 4 FAILED: ../keystrokes/oocalc/bug_356334.py:Press the right arrow to move to cell B2 EXPECTED: "BRAILLE LINE: 'soffice Application fruit - OpenOffice.org Calc Frame fruit - OpenOffice.org Calc RootPane ScrollPane Document view3 Sheet Sheet1 Table Yes Cell B2 '", " VISIBLE: 'Yes Cell B2 ', cursor=1", "SPEECH OUTPUT: 'Yes B2'", ACTUAL: "BRAILLE LINE: 'soffice Application Frame fruit - OpenOffice.org Calc RootPane ScrollPane Document view3 Sheet Sheet1 Table Yes Cell B2 '", " VISIBLE: 'Yes Cell B2 ', cursor=1", "SPEECH OUTPUT: 'Yes B2'", [FAILURE WAS UNEXPECTED] Test 4 of 4 FAILED: ../keystrokes/oocalc/bug_356334.py:Type Insert-f to get text attributes on the current cell (B2) EXPECTED: "BUG: not speaking anything", ACTUAL: "", [FAILURE WAS UNEXPECTED] SUMMARY: 0 SUCCEEDED and 4 FAILED (4 UNEXPECTED) of 4 for ../keystrokes/oocalc/bug_356334.py Once this patch is checked in, I'll start looking at these. Fixing them here probably means that a lot of the differences in the other tests will disappear too.
> Yes, this patch does make the "not selected" differences go away. Woo hoo! :-) > Unless there are any objections, I'd like to check this in ASAP Sounds good to me. It's.... What would Will say.... Low risk, high user impact? Something like that anyway. :-) > (both for SVN trunk and the gnome-2-22 branch). Joanie, that would > mean that the patch for bug #518914 should be adjusted not to include > that chunk. I will do that. > Also, (as you point out), there are other differences. Here's what > I now get for these four tests: Aside from the "not speaking anything" bugs, I think many of the failures across the board in the OOo tests are the differences in braille contexts resulting from the frame not have a name in the new version of OOo. If so, lots of easy fixes.
Patch committed to SVN trunk and gnome-2-22 branch. I'll now work on fixing up the remaining problems. Thanks!
Created attachment 107693 [details] [review] Patch to fix up regression tests #1 and #3. As Joanie points out, the expected results for tests #1 and #3 need to be adjusted, because there the frame does not have a name in the new version of OOo. This committed patch (to SVN trunk only) fixes that. Tests #2 and #4 fail because of Orca bug #480998 - "Insert-f to get text attribute information doesn't work in oocalc unless you are in text entry mode". This is really OOo issue #82480 http://www.openoffice.org/issues/show_bug.cgi?id=82480 which was opened in October last year and which unfortunately hasn't seen any action on yet. I'll block this bug against bug #480998 for now.
http://www.openoffice.org/issues/show_bug.cgi?id=82480 has been marked as FIXED. Marking this one as [to confirm].
Created attachment 115176 [details] [review] Patch to add new font information and to eliminate failures. Tested and confirmed using OODEV300_m27 build 9336 on my OpenSolaris box.