GNOME Bugzilla – Bug 523438
oowriter regression tests need work.
Last modified: 2008-06-04 18:10:34 UTC
Following on from bug #521651, here's the summaries of running the oowriter regression tests against OOo 2.4 dev (Release Candidate 6): SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_342602.py SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_350219.py SUMMARY: 3 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 3 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_353268.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_355733.py SUMMARY: 0 SUCCEEDED and 4 FAILED (4 UNEXPECTED) of 4 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361624.py SUMMARY: 0 SUCCEEDED and 4 FAILED (4 UNEXPECTED) of 4 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361747.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_362979.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_364765.py SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382408.py SUMMARY: 0 SUCCEEDED and 5 FAILED (5 UNEXPECTED) of 5 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382415.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382418.py SUMMARY: 0 SUCCEEDED and 8 FAILED (8 UNEXPECTED) of 8 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382880.py SUMMARY: 0 SUCCEEDED and 8 FAILED (8 UNEXPECTED) of 8 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382888.py SUMMARY: 1 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 3 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_384893.py SUMMARY: 0 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_385828.py SUMMARY: 1 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_413909.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_430402.py SUMMARY: 0 SUCCEEDED and 5 FAILED (5 UNEXPECTED) of 5 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435201.py SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435226.py SUMMARY: 0 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_450210.py SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_469367.py I'll attach the complete results in a moment. To divide this into manageable chunks, I'll file separate bugs for each of these failures (one bug per .py file). I also note that OOo spews out a load of WARNING messages: $ grep WARNING oowriter-test.txt | uniq -c 2 ** (soffice:24399): WARNING **: Unmapped KeyCode: 779 3 ** (soffice:24399): WARNING **: Exception in get_text_at_offset() 25 ** (soffice:24657): WARNING **: Exception in get_text_at_offset() 21 ** (soffice:24781): WARNING **: Exception in get_text_at_offset() 20 ** (soffice:25163): WARNING **: Exception in get_text_at_offset() 11 ** (soffice:25412): WARNING **: Exception in get_text_at_offset() 11 ** (soffice:25553): WARNING **: Exception in get_text_at_offset() 4 ** (soffice:25678): WARNING **: Exception in get_text_at_offset() 2 ** (soffice:25678): WARNING **: Unmapped KeyCode: 779 12 ** (soffice:25678): WARNING **: Exception in get_text_at_offset() 13 ** (soffice:25803): WARNING **: Exception in get_text_at_offset() 13 ** (soffice:25929): WARNING **: Exception in get_text_at_offset() 13 ** (soffice:26310): WARNING **: Exception in get_text_at_offset() 21 ** (soffice:26449): WARNING **: Exception in get_text_at_offset() 54 ** (soffice:26574): WARNING **: Exception in get_text_at_offset() 28 ** (soffice:26700): WARNING **: Exception in get_text_at_offset() 9 ** (soffice:26957): WARNING **: Exception in get_text_at_offset() I realize they are warnings, but they also worry me.
Created attachment 107647 [details] Results from running the Orca oowriter regression tests.
Created attachment 108611 [details] Results (4th April 2008) from running the Orca oowriter regression tests. Here's the results from running: $ cd /home/richb/gnome/orca/trunk/test/harness $ ./runall -a /home/richb/gnome/orca/trunk/keystrokes/oowriter SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_342602.py SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_350219.py SUMMARY: 0 SUCCEEDED and 3 FAILED (3 UNEXPECTED) of 3 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_353268.py SUMMARY: 1 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_355733.py SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361624.py SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361747.py SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_362979.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_364765.py SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382408.py SUMMARY: 3 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 5 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382415.py SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382418.py SUMMARY: 6 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 8 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382880.py SUMMARY: 6 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 8 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382888.py SUMMARY: 3 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 3 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_384893.py SUMMARY: 0 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_385828.py SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_413909.py SUMMARY: 1 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_430402.py SUMMARY: 0 SUCCEEDED and 5 FAILED (5 UNEXPECTED) of 5 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435201.py SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435226.py SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_450210.py SUMMARY: 1 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_469367.py Analysis to follow.
Here's an example of the EXPECTED and ACTUAL output for one of the tests that failed. The BRAILLE LINE output and the VISIBLE part have actually changed. Test 1 of 3 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_353268.py:Return to top of document EXPECTED: "BRAILLE LINE: ' $l'", " VISIBLE: ' $l', cursor=1", "BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view Line 1 $l'", " VISIBLE: 'Line 1 $l', cursor=1", "SPEECH OUTPUT: 'Line 1'", ACTUAL: "BRAILLE LINE: ' $l'", " VISIBLE: ' $l', cursor=0", "BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view Line 1 $l'", " VISIBLE: 'Line 1 $l', cursor=1", "SPEECH OUTPUT: 'Line 1'", [FAILURE WAS UNEXPECTED] I expect there are similar problems with a lot of the other results. Has there been any recent checkins to the braille code that might have caused this change?
Looks like it's just the braille cursor position that changed. A cursor position of '0' means no cursor is shown (i.e., 'cursor' is a 1-based index to match BrlAPI): < " VISIBLE: ' $l', cursor=1", --- > " VISIBLE: ' $l', cursor=0", > Has there been any recent checkins to the braille code that might have > caused this change? Well....there have been a bunch of changes recently for cursor routing. Eitan might be able to provide some insight into what (if anything) might have been affected in this space.
Created attachment 108616 [details] Results of oowriter regression tests with rev 3772. As a data point, I checked out rev 3772 of Orca (circa 26th March 2008), which was when I fixed most of the regression tests. See attached. Here's the summary: SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_342602.py SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_350219.py SUMMARY: 3 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 3 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_353268.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_355733.py SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_361624.py SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_361747.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_362979.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_364765.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_382408.py SUMMARY: 5 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 5 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_382415.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_382418.py SUMMARY: 8 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 8 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_382880.py SUMMARY: 8 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 8 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_382888.py SUMMARY: 3 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 3 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_384893.py SUMMARY: 0 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 1 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_385828.py SUMMARY: 1 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 2 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_413909.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_430402.py SUMMARY: 0 SUCCEEDED and 5 FAILED (5 UNEXPECTED) of 5 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_435201.py SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_435226.py SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_450210.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_469367.py That leaves the following that were still failing: SUMMARY: 0 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 1 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_385828.py SUMMARY: 1 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 2 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_413909.py ... SUMMARY: 0 SUCCEEDED and 5 FAILED (5 UNEXPECTED) of 5 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_435201.py SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_435226.py of those, I fixed the bug_385828.py one on 1st April 2008, so that's a known failure. I'll have a look at the other three now.
> SUMMARY: 1 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 2 for > /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_413909.py This is bug #523452 and is "[blocked]". > SUMMARY: 0 SUCCEEDED and 5 FAILED (5 UNEXPECTED) of 5 for > /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_435201.py This is known in-your-face expected output. We have a "BUG: speaks the paragraph three times"," line at the top of the EXPECTED output to force this to be different. > SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for > /home/richb/gnome/orca/rev_3772/test/keystrokes/oowriter/bug_435226.py This is bug #523455, and is awaiting an evaulation by Eitan. All present and accounted for. Back on March 26th 2008, that is.
Created attachment 108825 [details] Oowriter regression tests results against Orca rev 3821. With the braille changes that Eitan recently backed out I now get the following results when running the oowriter tests against latest SVN trunk: SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_342602.py SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_350219.py SUMMARY: 3 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 3 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_353268.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_355733.py SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361624.py SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361747.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_362979.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_364765.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382408.py SUMMARY: 5 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 5 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382415.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382418.py SUMMARY: 8 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 8 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382880.py SUMMARY: 8 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 8 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382888.py SUMMARY: 3 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 3 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_384893.py SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_385828.py SUMMARY: 1 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_413909.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_430402.py SUMMARY: 0 SUCCEEDED and 5 FAILED (5 UNEXPECTED) of 5 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435201.py SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435226.py SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_450210.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_469367.py That's the same as those in comment #5
This regression was introduced because I factored out the gnome-terminal hack that we had in braille.py. Apparently oowriter is benefiting from this too. http://svn.gnome.org/viewvc/orca/trunk/src/orca/braille.py?annotate=3807#l469 The line with activeScript.getTextLineAtCaret above it was sort of failing, the caret position returned is -1, and the string is empty. I'll hack up a StarOffice getTextLineAtCaret that should always return a sane result.
(In reply to comment #8) > This regression was introduced because I factored out the gnome-terminal hack > that we had in braille.py. Apparently oowriter is benefiting from this too. > > http://svn.gnome.org/viewvc/orca/trunk/src/orca/braille.py?annotate=3807#l469 > > The line with activeScript.getTextLineAtCaret above it was sort of failing, the > caret position returned is -1, and the string is empty. > > I'll hack up a StarOffice getTextLineAtCaret that should always return a sane > result. If the block of code was helping more than one application and not having a negative effect on other applications, would it be better to put it in a more general location (e.g., default.py)? Or, are gnome-terminal and SOffice failing in separate ways?
(In reply to comment #9) > If the block of code was helping more than one application and not having a > negative effect on other applications, would it be better to put it in a more > general location (e.g., default.py)? Or, are gnome-terminal and SOffice > failing in separate ways? > I see the current behavior (before my patch), as a fluke. open office and gnome-terminal have very different quirks, the gnome-terminal thing happens in vim when the cursor is in the upper left cell. The openoffice thing happens when you cursor in to a new paragraph, it is actually a more general bug too, say you have the following text: Line 1 Line 2 If you are on column 3 of line one, and you arrow down, the braille display will put the cursor on the first column for a very brief second before going to column 3, this is because the gnome-terminal hack normalizes the string, and sets the cursor to 0. I'll write a brief pyatspi test to demonstrate the openoffice quirk.
Actually, we don't need a test script, in Accerciser's event monitor, you could see that event.detail1 shows a -1 when you arrow into a new paragraph.
(In reply to comment #11) > Actually, we don't need a test script, in Accerciser's event monitor, you could > see that event.detail1 shows a -1 when you arrow into a new paragraph. > Aha - OK. I recall us chasing this around in some other bug (it might have been hearing too much info when across across paragraphs). If I recall, we get a whole series of events for the old and new paragraphs, with -1 being used in the caret moved events to indicate the caret is no longer visible. So...it may actually be that the new behavior your patch introduced is the more 'correct' one.
(In reply to comment #12) > So...it may actually be that the new behavior your patch introduced is the more > 'correct' one. > Well, not really correct. But neither is the status quo. I added two lines to StarOffice's onCaretMoved to return immediately if the caret position is -1, I think it is fairly safe to do, since a "good" caret moved event is always followed immediately with a valid caret position. I'm testing this against oowriter's tests now. and there is definitely a substantial diff. I'm looking at it case-by-case, and sometimes we are actually getting better output IMHO, but I am sure some stuff broke too.
(In reply to comment #13) > (In reply to comment #12) > > So...it may actually be that the new behavior your patch introduced is the more > > 'correct' one. > > > > Well, not really correct. But neither is the status quo. > I added two lines to StarOffice's onCaretMoved to return immediately if the > caret position is -1, I think it is fairly safe to do, since a "good" caret > moved event is always followed immediately with a valid caret position. That's probably OK, too. A -1 is meant to say "the caret is nowhere" in the 0-based index world of AT-SPI, so that would translate into a cursor offset of 0 in the 1-based index world of BrlATI.
Ok, I guess this could work fine. Removing the gnome-terminal hack from braille.py actually fixes bug #429390. Although I don't know what real regressions occur. Rich, could you give the patch in bug #520612 a try, and see if there is any unwanted behavior? For example the output in comment #3 is probably not all that bad. In real world use the braille displays blanks for a split of a second.
Created attachment 108945 [details] Oowriter regression test results against latest Orca with the brl patch from bug #520612 applied. > Rich, could you give the patch in bug #520612 a try, and see if there > is any unwanted behavior? I'm not sure if the differences are unwanted behavior or not. :-( Hopefully you and Mike will be able to tell from trying the regression tests manually. SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_342602.py SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_350219.py SUMMARY: 1 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 3 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_353268.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_355733.py SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361624.py SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361747.py SUMMARY: 1 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_362979.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_364765.py SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382408.py SUMMARY: 3 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 5 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382415.py SUMMARY: 1 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382418.py SUMMARY: 6 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 8 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382880.py SUMMARY: 6 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 8 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382888.py SUMMARY: 3 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 3 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_384893.py SUMMARY: 0 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_385828.py SUMMARY: 1 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_413909.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_430402.py SUMMARY: 0 SUCCEEDED and 5 FAILED (5 UNEXPECTED) of 5 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435201.py SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435226.py SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_450210.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_469367.py Here are the failures in more detail: Test 2 of 3 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_353268.py:Arrow down over first line of text DIFFERENCES FOUND: - BRAILLE LINE: 'Line 1 $l' ? ------ + BRAILLE LINE: ' $l' - VISIBLE: 'Line 1 $l', cursor=1 ? ------ + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view Line 2 $l' VISIBLE: 'Line 2 $l', cursor=1 SPEECH OUTPUT: 'Line 2' [FAILURE WAS UNEXPECTED] ------------------------- Test 3 of 3 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_353268.py:Arrow down over second line of text DIFFERENCES FOUND: - BRAILLE LINE: 'Line 2 $l' ? ------ + BRAILLE LINE: ' $l' - VISIBLE: 'Line 2 $l', cursor=1 ? ------ + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view $l' VISIBLE: ' $l', cursor=1 SPEECH OUTPUT: 'blank' [FAILURE WAS UNEXPECTED] ------------------------- Test 2 of 2 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_362979.py:Move to second bulleted line DIFFERENCES FOUND: /usr/lib/python2.5/difflib.py:436: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal a[besti+bestsize] == b[bestj+bestsize]: /usr/lib/python2.5/difflib.py:432: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal a[besti-1] == b[bestj-1]: - BRAILLE LINE: '•Line 1 $l' ? --------- + BRAILLE LINE: ' $l' + VISIBLE: ' $l', cursor=1 + BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view •Line 2 $l' - VISIBLE: '•Line 1 $l', cursor=1 ? ^^^ ^ ^ + VISIBLE: '•Line 2 $l', cursor=2 ? ^ ^ ^ - BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view •Line 2 $l' - VISIBLE: '•Line 2 $l', cursor=2 SPEECH OUTPUT: '•Line 2' [FAILURE WAS UNEXPECTED] ----------------------- Test 1 of 2 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382408.py:Type a down arrow to move to the next line DIFFERENCES FOUND: - BRAILLE LINE: 'December 2006 $l' ? ------------- + BRAILLE LINE: ' $l' - VISIBLE: 'December 2006 $l', cursor=1 ? ------------- + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame table-sample - OpenOffice.org Writer RootPane ScrollPane Document view This is a test. $l' VISIBLE: 'This is a test. $l', cursor=16 SPEECH OUTPUT: 'This is a test.' [FAILURE WAS UNEXPECTED] ------------------------ Test 2 of 2 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382408.py:Type a down arrow to move to the Mon table column header DIFFERENCES FOUND: - BRAILLE LINE: 'This is a test. $l' + BRAILLE LINE: ' $l' - VISIBLE: 'This is a test. $l', cursor=1 ? --------------- + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame table-sample - OpenOffice.org Writer RootPane ScrollPane Document view Calendar-1 Table Sun Mon Tue Wed Thu Fri Sat' VISIBLE: 'Mon Tue Wed Thu Fri Sat', cursor=1 SPEECH OUTPUT: 'Sun Mon Tue Wed Thu Fri Sat' SPEECH OUTPUT: ' not selected' [FAILURE WAS UNEXPECTED] ------------------------- Test 1 of 5 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382415.py:Down arrow to next line DIFFERENCES FOUND: - BRAILLE LINE: 'December 2006 $l' ? ------------- + BRAILLE LINE: ' $l' - VISIBLE: 'December 2006 $l', cursor=1 ? ------------- + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame table-sample - OpenOffice.org Writer RootPane ScrollPane Document view This is a test. $l' VISIBLE: 'This is a test. $l', cursor=16 SPEECH OUTPUT: 'This is a test.' [FAILURE WAS UNEXPECTED] ------------------------------ Test 2 of 5 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382415.py:Down arrow to move to the Mon table column header DIFFERENCES FOUND: - BRAILLE LINE: 'This is a test. $l' + BRAILLE LINE: ' $l' - VISIBLE: 'This is a test. $l', cursor=1 ? --------------- + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame table-sample - OpenOffice.org Writer RootPane ScrollPane Document view Calendar-1 Table Mon Paragraph' VISIBLE: 'Mon Paragraph', cursor=1 SPEECH OUTPUT: 'Cell B1' SPEECH OUTPUT: 'Mon' SPEECH OUTPUT: ' not selected' [FAILURE WAS UNEXPECTED] --------------------------- Test 2 of 2 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382418.py:Type a down arrow to enter the table DIFFERENCES FOUND: - BRAILLE LINE: 'Line 1 $l' ? ------ + BRAILLE LINE: ' $l' - VISIBLE: 'Line 1 $l', cursor=1 ? ------ + VISIBLE: ' $l', cursor=1 SPEECH OUTPUT: 'table with 2 rows and 2 columns.' SPEECH OUTPUT: 'Cell A1' [FAILURE WAS UNEXPECTED] --------------------------- Test 1 of 8 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382880.py:Type a down arrow to move to the next line DIFFERENCES FOUND: - BRAILLE LINE: 'December 2006 $l' ? ------------- + BRAILLE LINE: ' $l' - VISIBLE: 'December 2006 $l', cursor=1 ? ------------- + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame table-sample - OpenOffice.org Writer RootPane ScrollPane Document view This is a test. $l' VISIBLE: 'This is a test. $l', cursor=16 SPEECH OUTPUT: 'This is a test.' [FAILURE WAS UNEXPECTED] --------------------------- Test 2 of 8 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382880.py:Type a down arrow to move to the Mon table column header DIFFERENCES FOUND: - BRAILLE LINE: 'This is a test. $l' + BRAILLE LINE: ' $l' - VISIBLE: 'This is a test. $l', cursor=1 ? --------------- + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame table-sample - OpenOffice.org Writer RootPane ScrollPane Document view Calendar-1 Table Mon Paragraph' VISIBLE: 'Mon Paragraph', cursor=1 SPEECH OUTPUT: 'Cell B1' SPEECH OUTPUT: 'Mon' SPEECH OUTPUT: ' not selected' [FAILURE WAS UNEXPECTED] ------------------------- Test 1 of 8 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382888.py:Type a down arrow to move to the next line DIFFERENCES FOUND: - BRAILLE LINE: 'December 2006 $l' ? ------------- + BRAILLE LINE: ' $l' - VISIBLE: 'December 2006 $l', cursor=1 ? ------------- + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame table-sample - OpenOffice.org Writer RootPane ScrollPane Document view This is a test. $l' VISIBLE: 'This is a test. $l', cursor=16 SPEECH OUTPUT: 'This is a test.' [FAILURE WAS UNEXPECTED] -------------------------- Test 2 of 8 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382888.py:Type a down arrow to move to the Mon table column header DIFFERENCES FOUND: - BRAILLE LINE: 'This is a test. $l' + BRAILLE LINE: ' $l' - VISIBLE: 'This is a test. $l', cursor=1 ? --------------- + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame table-sample - OpenOffice.org Writer RootPane ScrollPane Document view Calendar-1 Table Mon Paragraph' VISIBLE: 'Mon Paragraph', cursor=1 SPEECH OUTPUT: 'Cell B1' SPEECH OUTPUT: 'Mon' SPEECH OUTPUT: ' not selected' [FAILURE WAS UNEXPECTED] --------------------------- Test 1 of 1 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_385828.py:Press 'a' to bring up the Agenda... wizard DIFFERENCES FOUND: BRAILLE LINE: 'soffice Application aw-5blue (read-only) - OpenOffice.org Writer Frame' VISIBLE: 'aw-5blue (read-only) - OpenOffic', cursor=1 BRAILLE LINE: 'soffice Application Agenda Wizard Dialog' VISIBLE: 'Agenda Wizard Dialog', cursor=1 - BRAILLE LINE: 'soffice Application Agenda Wizard Dialog Steps Panel Page design $l' ? ----------- + BRAILLE LINE: 'soffice Application Agenda Wizard Dialog Steps Panel $l' - VISIBLE: 'Page design $l', cursor=1 ? ----------- + VISIBLE: ' $l', cursor=1 SPEECH OUTPUT: '' SPEECH OUTPUT: 'aw-5blue (read-only) - OpenOffice.org Writer frame' SPEECH OUTPUT: '' SPEECH OUTPUT: 'Agenda Wizard' SPEECH OUTPUT: '' SPEECH OUTPUT: 'Page design label' [FAILURE WAS UNEXPECTED] ---------------------------- Test 2 of 2 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_413909.py:Enter F7 to bring up the spell checking dialog DIFFERENCES FOUND: BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=2 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=3 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=4 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=5 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=23 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=14 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=15 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=16 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=17 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=18 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=19 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=20 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=21 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=22 BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view The quuuiick brown fox $l' VISIBLE: 'The quuuiick brown fox $l', cursor=23 BRAILLE LINE: 'soffice Application Spellcheck: (English (USA)) Dialog' VISIBLE: 'Spellcheck: (English (USA)) Dia', cursor=1 - BRAILLE LINE: 'soffice Application Spellcheck: (English (USA)) Dialog Spellcheck: (English (USA)) OptionPane Change Button' ? ---------------------------------------- + BRAILLE LINE: 'soffice Application Spellcheck: (English (USA)) Dialog Change Button' VISIBLE: 'Change Button', cursor=1 SPEECH OUTPUT: '' SPEECH OUTPUT: 'Spellcheck: (English (USA))' - SPEECH OUTPUT: 'Misspelled word: quuuiick Context is The quuuiick brown fox' SPEECH OUTPUT: '' SPEECH OUTPUT: 'Change button' [FAILURE WAS UNEXPECTED] ----------------------------- Test 1 of 5 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435201.py:Type Control-down to move to the next paragraph [1] DIFFERENCES FOUND: - BUG: speaks the paragraph three times BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view NOBODY expects the Spanish Inquisition! Our chief weapon is surprise. Surprise and $l' VISIBLE: 'NOBODY expects the Spanish Inqui', cursor=2 BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view NOBODY expects the Spanish Inquisition! Our chief weapon is surprise. Surprise and $l' VISIBLE: 'NOBODY expects the Spanish Inqui', cursor=1 - BRAILLE LINE: 'NOBODY expects the Spanish Inquisition! Our chief weapon is surprise. Surprise and $l' - VISIBLE: 'NOBODY expects the Spanish Inqui', cursor=1 + BRAILLE LINE: ' $l' + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view NOBODY expects the Spanish Inquisition! Amongst our weaponry are such diverse $l' VISIBLE: 'NOBODY expects the Spanish Inqui', cursor=1 SPEECH OUTPUT: 'NOBODY expects the Spanish Inquisition! Our chief weapon is surprise. Surprise and ' SPEECH OUTPUT: 'NOBODY expects the Spanish Inquisition! Our chief weapon is surprise. Surprise and ' SPEECH OUTPUT: 'NOBODY expects the Spanish Inquisition! Amongst our weaponry are such diverse ' [FAILURE WAS UNEXPECTED] ---------------------------- Test 2 of 5 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435201.py:Type Control-down to move to the next paragraph [2] DIFFERENCES FOUND: - BUG: speaks the paragraph two times BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view NOBODY expects the Spanish Inquisition! Amongst our weaponry are such diverse $l' VISIBLE: 'NOBODY expects the Spanish Inqui', cursor=2 BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view NOBODY expects the Spanish Inquisition! Amongst our weaponry are such diverse $l' VISIBLE: 'NOBODY expects the Spanish Inqui', cursor=1 - BRAILLE LINE: 'NOBODY expects the Spanish Inquisition! Amongst our weaponry are such diverse $l' - VISIBLE: 'NOBODY expects the Spanish Inqui', cursor=1 + BRAILLE LINE: ' $l' + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view $l' VISIBLE: ' $l', cursor=1 SPEECH OUTPUT: 'NOBODY expects the Spanish Inquisition! Amongst our weaponry are such diverse ' SPEECH OUTPUT: 'NOBODY expects the Spanish Inquisition! Amongst our weaponry are such diverse ' SPEECH OUTPUT: 'blank' [FAILURE WAS UNEXPECTED] -------------------------- Test 3 of 5 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435201.py:Type Control-down to move to the next paragraph [3] DIFFERENCES FOUND: - BUG: speaks the paragraph two times BRAILLE LINE: ' $l' VISIBLE: ' $l', cursor=1 - BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Now old lady, you have one last chance. Confess the heinous sin of heresy, reject $l' ? - + BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Now old lady, you have one last chance. Confess the heinous sin of heresy, reject $l' VISIBLE: 'Now old lady, you have one last ', cursor=1 - BRAILLE LINE: 'Now old lady, you have one last chance. Confess the heinous sin of heresy, reject $l' - VISIBLE: 'Now old lady, you have one last ', cursor=1 + BRAILLE LINE: ' $l' + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view $l' VISIBLE: ' $l', cursor=1 BRAILLE LINE: ' $l' VISIBLE: ' $l', cursor=1 - BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Now old lady, you have one last chance. Confess the heinous sin of heresy, reject $l' ? - + BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Now old lady, you have one last chance. Confess the heinous sin of heresy, reject $l' VISIBLE: 'Now old lady, you have one last ', cursor=1 SPEECH OUTPUT: 'Now old lady, you have one last chance. Confess the heinous sin of heresy, reject ' SPEECH OUTPUT: 'blank' SPEECH OUTPUT: 'Now old lady, you have one last chance. Confess the heinous sin of heresy, reject ' [FAILURE WAS UNEXPECTED] ---------------------------- Test 4 of 5 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435201.py:Type Control-down to move to the next paragraph [4] DIFFERENCES FOUND: - BUG: speaks the paragraph two times - BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Now old lady, you have one last chance. Confess the heinous sin of heresy, reject $l' ? - + BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Now old lady, you have one last chance. Confess the heinous sin of heresy, reject $l' VISIBLE: 'Now old lady, you have one last ', cursor=2 - BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Now old lady, you have one last chance. Confess the heinous sin of heresy, reject $l' ? - + BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Now old lady, you have one last chance. Confess the heinous sin of heresy, reject $l' VISIBLE: 'Now old lady, you have one last ', cursor=1 - BRAILLE LINE: 'Now old lady, you have one last chance. Confess the heinous sin of heresy, reject $l' - VISIBLE: 'Now old lady, you have one last ', cursor=1 + BRAILLE LINE: ' $l' + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view $l' VISIBLE: ' $l', cursor=1 SPEECH OUTPUT: 'Now old lady, you have one last chance. Confess the heinous sin of heresy, reject ' SPEECH OUTPUT: 'Now old lady, you have one last chance. Confess the heinous sin of heresy, reject ' SPEECH OUTPUT: 'blank' [FAILURE WAS UNEXPECTED] ------------------------- Test 5 of 5 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435201.py:Type Control-down to move to the next paragraph [5] DIFFERENCES FOUND: - BUG: speaks the paragraph two times BRAILLE LINE: ' $l' VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' VISIBLE: 'Hm! She is made of harder stuff!', cursor=1 - BRAILLE LINE: 'Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' - VISIBLE: 'Hm! She is made of harder stuff!', cursor=1 + BRAILLE LINE: ' $l' + VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view $l' VISIBLE: ' $l', cursor=1 BRAILLE LINE: ' $l' VISIBLE: ' $l', cursor=1 BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' VISIBLE: 'Hm! She is made of harder stuff!', cursor=1 SPEECH OUTPUT: 'Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR!' SPEECH OUTPUT: 'blank' SPEECH OUTPUT: 'Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR!' [FAILURE WAS UNEXPECTED] --------------------------- Test 1 of 2 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435226.py:Type KP-Enter once to do a 'single-click' where-am-I operation DIFFERENCES FOUND: - BRAILLE LINE: 'soffice Application spanish - OpenOffice.org Writer Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' ? -------------------------------- + BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' VISIBLE: 'Hm! She is made of harder stuff!', cursor=17 - SPEECH OUTPUT: '' - SPEECH OUTPUT: 'paragraph' - SPEECH OUTPUT: 'Hm! She is made ' - SPEECH OUTPUT: 'selected' - SPEECH OUTPUT: '' [FAILURE WAS UNEXPECTED] --------------------------- Test 2 of 2 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435226.py:Type KP-Enter twice to do a 'double-click' where-am-I operation DIFFERENCES FOUND: - BRAILLE LINE: 'soffice Application spanish - OpenOffice.org Writer Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' ? -------------------------------- + BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' VISIBLE: 'Hm! She is made of harder stuff!', cursor=17 - BRAILLE LINE: 'soffice Application spanish - OpenOffice.org Writer Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' ? -------------------------------- + BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' VISIBLE: 'Hm! She is made of harder stuff!', cursor=17 - SPEECH OUTPUT: '' - SPEECH OUTPUT: 'paragraph' - SPEECH OUTPUT: 'Hm! She is made ' - SPEECH OUTPUT: 'selected' - SPEECH OUTPUT: '' - SPEECH OUTPUT: '' - SPEECH OUTPUT: 'paragraph' - SPEECH OUTPUT: 'Spanish Inquisition! Our chief weapon is surprise. Surprise and fear. Fear and surprise. Our two weapons are fear and surprise. And ruthless efficiency. Our three weapons are fear, surprise, and ruthless efficiency. And an almost fanatical devotion to the Pope. Our four. No. Amongst our weapons. Amongst our weaponry, are such elements as fear, surprise. I'll come in again. NOBODY expects the Spanish Inquisition! Amongst our weaponry are such diverse elements as: fear, surprise, ruthless efficiency, an almost fanatical devotion to the Pope, and nice red uniforms - Oh damn! Now old lady, you have one last chance. Confess the heinous sin of heresy, reject the works of the ungodly. Two last chances. And you shall be free. Three last chances. You have three last chances, the nature of which I have divulged in my previous utterance. Hm! She is made ' - SPEECH OUTPUT: 'selected' - SPEECH OUTPUT: '' [FAILURE WAS UNEXPECTED]
Created attachment 110134 [details] [review] Patch to fixup most regression test failures. With this patch committed there are now three remaining failures (of which 1 still needs to be resolved): SUMMARY: 1 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_413909.py This is bug #523452 and is "[blocked]". SUMMARY: 0 SUCCEEDED and 5 FAILED (5 UNEXPECTED) of 5 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435201.py This is known in-your-face expected output. We have a "BUG: speaks the paragraph three times"," line at the top of the EXPECTED output to force this to be different. SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435226.py This was bug #523455 and even though it's been closed out as FIXED, I don't think the regression test output (see below) is correct. I'll need investigate this one further. ---- Running /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435226.py starting test application oowriter -norestore /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/spanish.odt ... Macaroon timeout: Wait for paragraph to be focused ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() ** (soffice:30802): WARNING **: Exception in get_text_at_offset() Test 1 of 2 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435226.py:Type KP-Enter once to do a 'single-click' where-am-I operation DIFFERENCES FOUND: - BRAILLE LINE: 'soffice Application spanish - OpenOffice.org Writer Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' ? -------------------------------- + BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' VISIBLE: 'Hm! She is made of harder stuff!', cursor=17 - SPEECH OUTPUT: '' - SPEECH OUTPUT: 'paragraph' - SPEECH OUTPUT: 'Hm! She is made ' - SPEECH OUTPUT: 'selected' - SPEECH OUTPUT: '' [FAILURE WAS UNEXPECTED] Test 2 of 2 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435226.py:Type KP-Enter twice to do a 'double-click' where-am-I operation DIFFERENCES FOUND: - BRAILLE LINE: 'soffice Application spanish - OpenOffice.org Writer Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' ? -------------------------------- + BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' VISIBLE: 'Hm! She is made of harder stuff!', cursor=17 - BRAILLE LINE: 'soffice Application spanish - OpenOffice.org Writer Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' ? -------------------------------- + BRAILLE LINE: 'soffice Application Frame spanish - OpenOffice.org Writer RootPane ScrollPane Document view Hm! She is made of harder stuff! Cardinal Fang! Fetch the COMFY CHAIR! $l' VISIBLE: 'Hm! She is made of harder stuff!', cursor=17 - SPEECH OUTPUT: '' - SPEECH OUTPUT: 'paragraph' - SPEECH OUTPUT: 'Hm! She is made ' - SPEECH OUTPUT: 'selected' - SPEECH OUTPUT: '' - SPEECH OUTPUT: '' - SPEECH OUTPUT: 'paragraph' - SPEECH OUTPUT: 'Spanish Inquisition! Our chief weapon is surprise. Surprise and fear. Fear and surprise. Our two weapons are fear and surprise. And ruthless efficiency. Our three weapons are fear, surprise, and ruthless efficiency. And an almost fanatical devotion to the Pope. Our four. No. Amongst our weapons. Amongst our weaponry, are such elements as fear, surprise. I'll come in again. NOBODY expects the Spanish Inquisition! Amongst our weaponry are such diverse elements as: fear, surprise, ruthless efficiency, an almost fanatical devotion to the Pope, and nice red uniforms - Oh damn! Now old lady, you have one last chance. Confess the heinous sin of heresy, reject the works of the ungodly. Two last chances. And you shall be free. Three last chances. You have three last chances, the nature of which I have divulged in my previous utterance. Hm! She is made ' - SPEECH OUTPUT: 'selected' - SPEECH OUTPUT: '' [FAILURE WAS UNEXPECTED] SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435226.py /usr/bin/orca: line 98: 30776 Killed /usr/bin/python -c "import orca.orca; orca.orca.main()" "$ARGS" /home/richb/gnome/orca/trunk/test/harness/runone.sh: line 187: 30783 Killed $APP_NAME $ARGS $PARAMS Finished running /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435226.py.
That's interesting. When I ran that test I got no failures. Do you have the very latest pyatspi?
No I didn't. That was it. That test now works fine (apart from over 1300 exceptions in get_run_attributes() in soofice -- which is only a WARNING :-). Okay, that's everything accounted for then. Moving this to "[pending]". Thanks! ---- $ ./runone.sh ../keystrokes/oo writer/bug_435226.py oowriter 0 starting test application oowriter -norestore ../keystrokes/oowriter/spanish.odt ... Macaroon timeout: Wait for paragraph to be focused ** (soffice:29690): WARNING **: Exception in get_text_at_offset() ... ** (soffice:29690): WARNING **: Exception in get_text_at_offset() Test 1 of 2 SUCCEEDED: ../keystrokes/oowriter/bug_435226.py:Type KP-Enter once to do a 'single-click' where-am-I operation ** (soffice:29690): WARNING **: Exception in get_run_attributes() ... hundreds of similar lines deleted ... ** (soffice:29690): WARNING **: Exception in get_run_attributes() ** (soffice:29690): WARNING **: Exception in get_run_attributes() Test 2 of 2 SUCCEEDED: ../keystrokes/oowriter/bug_435226.py:Type KP-Enter twice to do a 'double-click' where-am-I operation SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for ../keystrokes/oowriter/bug_435226.py /usr/bin/orca: line 98: 29664 Killed /usr/bin/python -c "import orca.orca; orca.orca.main()" "$ARGS" ./runone.sh: line 187: 29671 Killed $APP_NAME $ARGS $PARAMS
Created attachment 110933 [details] [review] Patch to use regular expressions more for differences in OOo window titles This patch attempts to accommodate OOo's desire to change the title of windows between releases, yet keep the functionality the same. The main change was adding this to utils.py: +# Various OpenOffice names as a regex. These are needed because OOo likes +# to do various things with its window titles from release to release. +# These regex's attempt to provide a way to manage those differences. +# +OOoNames = "(OpenOffice.org Writer|OOo-dev Writer Beta)" +def getOOoTitleRegEx(title, remainder): + return "soffice Application( " + title + "|)(.odt|)( - )(" + OOoNames[1:-1] + "|) Frame (" + title + ")(.odt|) - (OpenOffice.org Writer|OOo-dev Writer Beta) RootPane ScrollPane Document view " + remainder + It comes up with a crazy regular expression based upon the relevant title (e.g., "example_document") and non-contextual stuff to be presented (i.e., the 'remainder'). This is then used throughout the tests. The good thing about this is that if OOo changes their mind on hierarchy or window title style, we can just change this regex and not have to change all the tests. I also put a try/except clause around the d.compare code in utils.py since it seemed to croak on some stuff (I'm guessing strings with multibyte UTF-8 characters in them, like the ones for bullets). In testing on Solaris with OOo 3.0 beta and OOo 2.4.0, this seems to work OK, though I see issues in bug_362979.py (has strings with bullets in them), bug_413909.py (has extra "unselected" output in it, probably unrelated to this), and bug_435201.py (just has "BUG?" lines for all the assertions). In any case, Rich - if you can test this and let me know what you think, we can either adjust it, check it in, or toss it. :-)
Created attachment 110936 [details] oowriter regression test results - Ubuntu Hardy - with regex patch applied. Here's the summary. As far as I can see, these are all known issues and bugs. Onto the oocalc tests... SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_342602.py SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_350219.py SUMMARY: 3 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 3 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_353268.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_355733.py SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361624.py SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361747.py SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_362979.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_364765.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382408.py SUMMARY: 5 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 5 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382415.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382418.py SUMMARY: 8 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 8 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382880.py SUMMARY: 8 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 8 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382888.py SUMMARY: 3 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 3 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_384893.py SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_385828.py SUMMARY: 1 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_413909.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_430402.py SUMMARY: 0 SUCCEEDED and 5 FAILED (5 UNEXPECTED) of 5 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435201.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435226.py SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_450210.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_469367.py
Created attachment 110937 [details] oocalc regression test results - Ubuntu Hardy - with regex patch applied. Here's the summary. There are a couple instances of a missing blank line being spoken. That might be considered an improvement. SUMMARY: 2 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 4 for /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_356334.py SUMMARY: 10 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 10 for /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_361167.py SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_363801.py SUMMARY: 6 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 6 for /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_363802.py SUMMARY: 6 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 6 for /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_363804.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_364086.py SUMMARY: 2 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 3 for /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_364407.py SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_433398.py SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_435307.py SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_435852.py
(In reply to comment #22) > Created an attachment (id=110937) [edit] > oocalc regression test results - Ubuntu Hardy - with regex patch applied. > > Here's the summary. There are a couple instances of a missing blank > line being spoken. That might be considered an improvement. > > SUMMARY: 2 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 4 for > /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_356334.py > SUMMARY: 10 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 10 for > /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_361167.py > SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for > /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_363801.py > SUMMARY: 6 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 6 for > /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_363802.py > SUMMARY: 6 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 6 for > /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_363804.py > SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for > /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_364086.py > SUMMARY: 2 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 3 for > /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_364407.py > SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for > /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_433398.py > SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for > /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_435307.py > SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for > /home/richb/gnome/orca/trunk/test/keystrokes/oocalc/bug_435852.py > (In reply to comment #21) > Created an attachment (id=110936) [edit] > oowriter regression test results - Ubuntu Hardy - with regex patch applied. > > Here's the summary. As far as I can see, these are all known > issues and bugs. Onto the oocalc tests... > > SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_342602.py > SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_350219.py > SUMMARY: 3 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 3 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_353268.py > SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_355733.py > SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361624.py > SUMMARY: 4 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 4 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361747.py > SUMMARY: 0 SUCCEEDED and 2 FAILED (2 UNEXPECTED) of 2 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_362979.py > SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_364765.py > SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382408.py > SUMMARY: 5 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 5 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382415.py > SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382418.py > SUMMARY: 8 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 8 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382880.py > SUMMARY: 8 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 8 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_382888.py > SUMMARY: 3 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 3 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_384893.py > SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_385828.py > SUMMARY: 1 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 2 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_413909.py > SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_430402.py > SUMMARY: 0 SUCCEEDED and 5 FAILED (5 UNEXPECTED) of 5 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435201.py > SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_435226.py > SUMMARY: 1 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 1 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_450210.py > SUMMARY: 2 SUCCEEDED and 0 FAILED (0 UNEXPECTED) of 2 for > /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_469367.py >
Ignore that last comment. It was a button press gone astray. > (In reply to comment #21) > > Created an attachment (id=110936) [edit] > > oowriter regression test results - Ubuntu Hardy - with regex patch applied. Thanks! These were basically only oowriter regression test changes. What I plan on doing is trying out Oliver Braun's hierarchy bug fix patch, expecting it to change the hierarchy. :-) That might tell me if the potential wins of the regex approach are actual wins, and then I can move on to the oocalc tests.
(In reply to comment #24) > Ignore that last comment. It was a button press gone astray. > > > (In reply to comment #21) > > > Created an attachment (id=110936) [edit] > > > oowriter regression test results - Ubuntu Hardy - with regex patch applied. > > Thanks! These were basically only oowriter regression test changes. > > What I plan on doing is trying out Oliver Braun's hierarchy bug fix patch, > expecting it to change the hierarchy. :-) That might tell me if the potential > wins of the regex approach are actual wins, and then I can move on to the > oocalc tests. > The regex's seem to work, but when the tests fail, they are a bunch of red herrings that hide the real failure. The reason being is that a compare of the regex to the actual string will naturally fail since it is a string match. Not sure what we should do here. Part of me says that updating the tests for each OOo release is expensive and we should just take the red herring hit. Thoughts?
I've trained myself to recognize these as regex expected failures now, so personally I'd rather not keep having to change them each release. Unless you can automate that part.